This repository was archived by the owner on Apr 15, 2024. It is now read-only.
Remove generics over the PRP
#232
arnauorriols
started this conversation in
Code design & architecture
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
While it's not a bad design per se to be generic over the Psuedorandom Permutation used within Spongos, when imagining a parallel universe where Streams is not plagued with the infamous
F: PRPit's almost too tempting to get rid of it, on the grounds of simplicity and YAGNI.Benefits of getting rid of
PRPtrait and assumingKeccak1600:PRPbound in the majority of them:GenericArrayGenericArrayin the upcoming PR, butPRPwas a resisting feud.PhantomDataof the applicationDrawbacks:
Beta Was this translation helpful? Give feedback.
All reactions