Skip to content

Commit e04eccc

Browse files
christian-bromannbrandyscarneythetaPC
authored
breaking: modernize project (#1447)
* chore: update project dependencies * remove lerna * update build * plugin fixes * Icons do not display when the svg is loaded from a file:// URL in Safari fixes #1298 * Update path fill in warning-outline.svg exclamation mark * set currentColor - fixes #1420 * add bell tag to notifications icon - fixes #1090 * add sliders and filters tags to option icon - fixes #1060 * add loveseat tag to bed icon - closes #503 * add contacts tag to people-circle closes #779 * fix data.json * update data.json * set up prettier * fix contributing link * prettier after rebase * add missing rimraf * add more comments * run prettier as part of the build * set module resolution to bundle * consolidate contributing guidelines and coc as part of the root directory * fix link * copy svg into www * cut me some visual slack * Update readme.md Co-authored-by: Brandy Smith <[email protected]> * Update package.json Co-authored-by: Maria Hutt <[email protected]> * Update CONTRIBUTING.md Co-authored-by: Maria Hutt <[email protected]> * remove generating collections * ensure all directories exist * only define snapshot tolerance in config * update dependencies * Update src/components/icon/request.ts Co-authored-by: Brandy Smith <[email protected]> * Update src/components/icon/request.ts Co-authored-by: Brandy Smith <[email protected]> * Update src/components/icon/request.ts Co-authored-by: Brandy Smith <[email protected]> * Update src/components/icon/request.ts Co-authored-by: Brandy Smith <[email protected]> * prettier * update release pipeline * fix exports * recommend to use esm.sh as cdn --------- Co-authored-by: Brandy Smith <[email protected]> Co-authored-by: Maria Hutt <[email protected]>
1 parent 5266d14 commit e04eccc

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+8664
-25848
lines changed

.github/CONTRIBUTING.md

Lines changed: 0 additions & 80 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/bug_report.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: 🐛 Bug Report
22
description: Report a bug in the ion-icon component. Incorrect icons should use the "Incorrect Icon" template instead.
3-
labels: ["triage"]
4-
title: "bug: "
3+
labels: ['triage']
4+
title: 'bug: '
55
body:
66
- type: textarea
77
attributes:

.github/ISSUE_TEMPLATE/feature_request.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: 💡 Feature Request
22
description: Suggest a new feature for the ion-icon component. Icon requests should use the "Icon Request" template instead.
3-
labels: ["triage"]
4-
title: "feat: "
3+
labels: ['triage']
4+
title: 'feat: '
55
body:
66
- type: textarea
77
attributes:
@@ -20,4 +20,4 @@ body:
2020
- type: textarea
2121
attributes:
2222
label: Additional Information
23-
description: Add any other context or screenshots about the feature request here.
23+
description: Add any other context or screenshots about the feature request here.

.github/ISSUE_TEMPLATE/icon_request.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: 🚀 Icon Request
22
description: Request a new icon
3-
labels: ["triage"]
4-
title: "icon request: "
3+
labels: ['triage']
4+
title: 'icon request: '
55
body:
66
- type: textarea
77
attributes:
@@ -16,4 +16,4 @@ body:
1616
- type: textarea
1717
attributes:
1818
label: Additional Information
19-
description: Add any other context about the icon request here.
19+
description: Add any other context about the icon request here.

.github/ISSUE_TEMPLATE/incorrect_icon.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: 😒 Incorrect Icon
22
description: Report an incorrect icon
3-
labels: ["triage"]
4-
title: "incorrect icon: "
3+
labels: ['triage']
4+
title: 'incorrect icon: '
55
body:
66
- type: textarea
77
attributes:
@@ -14,4 +14,4 @@ body:
1414
label: Expected Behavior
1515
description: A clear description of what the icon should look like. Please include any relevant screenshots.
1616
validations:
17-
required: true
17+
required: true

.github/ionic-issue-bot.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ closeAndLock:
2626

2727
comment:
2828
labels:
29-
- label: "help wanted"
29+
- label: 'help wanted'
3030
message: >
3131
This issue has been labeled as `help wanted`. This label is added to issues
3232
that we believe would be good for contributors.
@@ -54,13 +54,13 @@ comment:
5454
5555
If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was
5656
not enough for our team to reproduce the issue.
57-
- label: "community feedback wanted"
57+
- label: 'community feedback wanted'
5858
message: >
5959
This issue has been labeled as `community feedback wanted`. This label is added to issues that we would like to hear from the community on before moving forward with any final decision on the feature request.
6060
6161
6262
If the requested feature is something you would find useful for your applications, please react to the original post with 👍 (`+1`). If you would like to provide an additional use case for the feature, please post a comment.
63-
63+
6464
6565
The team will review this feedback and make a final decision. Any decision will be posted on this thread, but please note that we may ultimately decide not to pursue this feature.
6666
@@ -71,7 +71,7 @@ comment:
7171
noReply:
7272
days: 14
7373
maxIssuesPerRun: 100
74-
label: "needs: reply"
74+
label: 'needs: reply'
7575
responseLabel: triage
7676
exemptProjects: true
7777
exemptMilestones: true
@@ -89,7 +89,7 @@ noReply:
8989
noReproduction:
9090
days: 14
9191
maxIssuesPerRun: 100
92-
label: "ionitron: needs reproduction"
92+
label: 'ionitron: needs reproduction'
9393
responseLabel: triage
9494
exemptProjects: true
9595
exemptMilestones: true

.github/workflows/actions/build-core/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,4 +31,4 @@ runs:
3131
with:
3232
name: ionicons-src
3333
output: IoniconsSrc.zip
34-
paths: src
34+
paths: src

.github/workflows/actions/download-archive/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ runs:
1616
path: ${{ inputs.path }}
1717
- name: Exract Archive
1818
run: unzip -q -o ${{ inputs.path }}/${{ inputs.filename }}
19-
shell: bash
19+
shell: bash

.github/workflows/actions/publish-npm/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ runs:
1717
steps:
1818
- uses: actions/setup-node@v4
1919
with:
20-
node-version: 18.x
20+
node-version: 22.x
2121
- name: Install latest npm
2222
run: npm install -g npm@latest
2323
shell: bash

.github/workflows/actions/test-e2e/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,4 +81,4 @@ runs:
8181
with:
8282
name: test-results-${{ inputs.shard }}-${{ inputs.totalShards }}
8383
output: TestResults-${{ inputs.shard }}-${{ inputs.totalShards }}.zip
84-
paths: playwright-report
84+
paths: playwright-report

.github/workflows/actions/update-reference-screenshots/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,4 @@ runs:
3535
git add src/\*.png --force
3636
git commit -m "chore(): add updated snapshots"
3737
git push
38-
shell: bash
38+
shell: bash

.github/workflows/actions/upload-archive/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ runs:
1616
- uses: actions/upload-artifact@v4
1717
with:
1818
name: ${{ inputs.name }}
19-
path: ${{ inputs.output }}
19+
path: ${{ inputs.output }}

.github/workflows/build.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: 'Ionicons Build'
22

33
on:
44
pull_request:
5-
branches: [ '**' ]
5+
branches: ['**']
66

77
# When pushing a new commit we should
88
# cancel the previous test run to not
@@ -27,7 +27,7 @@ jobs:
2727
steps:
2828
- uses: actions/checkout@v4
2929
- uses: ./.github/workflows/actions/test-spec
30-
30+
3131
test-e2e:
3232
strategy:
3333
# This ensures that all screenshot shard
@@ -51,7 +51,7 @@ jobs:
5151
with:
5252
shard: ${{ matrix.shard }}
5353
totalShards: ${{ matrix.totalShards }}
54-
54+
5555
# Screenshots are required to pass
5656
# in order for the branch to be merge
5757
# eligible. However, the screenshot tests
@@ -68,4 +68,4 @@ jobs:
6868
steps:
6969
- name: Check build matrix status
7070
if: ${{ needs.test-e2e.result != 'success' }}
71-
run: exit 1
71+
run: exit 1

.github/workflows/release-ionicons.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ jobs:
2121
permissions:
2222
id-token: write
2323
steps:
24-
- uses: actions/checkout@v4
25-
- uses: ./.github/workflows/actions/publish-npm
26-
with:
27-
tag: ${{ inputs.tag }}
28-
version: ${{ inputs.version }}
29-
working-directory: './'
30-
token: ${{ secrets.NPM_TOKEN }}
24+
- uses: actions/checkout@v4
25+
- uses: ./.github/workflows/actions/publish-npm
26+
with:
27+
tag: ${{ inputs.tag }}
28+
version: ${{ inputs.version }}
29+
working-directory: './'
30+
token: ${{ secrets.NPM_TOKEN }}

.github/workflows/release.yml

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -26,36 +26,36 @@ jobs:
2626
version: ${{ inputs.version }}
2727
secrets:
2828
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
29-
29+
3030
finalize-release:
3131
needs: [release-ionicons]
3232
runs-on: ubuntu-latest
3333
steps:
34-
- uses: actions/checkout@v4
35-
with:
36-
token: ${{ secrets.IONITRON_TOKEN }}
37-
fetch-depth: 0
38-
- name: Configure Identity
39-
# Commits from github-actions do not
40-
# trigger other GitHub Actions. As a result,
41-
# we publish releases from Ionitron instead
42-
# so actions run when merging the release branch
43-
# back into main.
44-
run: |
45-
git config user.name ionitron
46-
git config user.email [email protected]
47-
shell: bash
48-
# This ensures the local version of Lerna is installed
49-
# and that we do not use the global Lerna version. We currently
50-
# rely on functionality that does not exist in newer versions of Lerna.
51-
- name: Install root dependencies
52-
run: npm ci
53-
shell: bash
54-
- name: Create GitHub Release
55-
run: npx lerna@5 version ${{ inputs.version }} --yes --force-publish='*' --conventional-commits --create-release github
56-
env:
57-
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
58-
shell: bash
34+
- uses: actions/checkout@v4
35+
with:
36+
token: ${{ secrets.IONITRON_TOKEN }}
37+
fetch-depth: 0
38+
- name: Configure Identity
39+
# Commits from github-actions do not
40+
# trigger other GitHub Actions. As a result,
41+
# we publish releases from Ionitron instead
42+
# so actions run when merging the release branch
43+
# back into main.
44+
run: |
45+
git config user.name ionitron
46+
git config user.email [email protected]
47+
shell: bash
48+
# This ensures the local version of Lerna is installed
49+
# and that we do not use the global Lerna version. We currently
50+
# rely on functionality that does not exist in newer versions of Lerna.
51+
- name: Install root dependencies
52+
run: npm ci
53+
shell: bash
54+
- name: Create GitHub Release
55+
run: npx lerna@5 version ${{ inputs.version }} --yes --force-publish='*' --conventional-commits --create-release github
56+
env:
57+
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
58+
shell: bash
5959

6060
update-package-lock:
6161
# This needs to run after finalize-release

.github/workflows/update-screenshots.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,4 @@ jobs:
4949
# to run when the screenshots are pushed.
5050
with:
5151
token: ${{ secrets.IONITRON_TOKEN }}
52-
- uses: ./.github/workflows/actions/update-reference-screenshots
52+
- uses: ./.github/workflows/actions/update-reference-screenshots

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,4 @@ www/
2424
/playwright-report/
2525
/playwright/.cache/
2626
/src/**/*-snapshots
27+
*.tgz
File renamed without changes.

0 commit comments

Comments
 (0)