chore: sync with main

Author: liamdebeasi

.github/ionic-issue-bot.yml

@@ -54,6 +54,18 @@ comment:
 
         If you have already provided a code snippet and are seeing this message, it is likely that the code snippet was
         not enough for our team to reproduce the issue.
+    - label: "community feedback wanted"
+      message: >
+        This issue has been labeled as `community feedback wanted`. This label is added to issues that we would like to hear from the community on before moving forward with any final decision on the feature request.
+
+
+        If the requested feature is something you would find useful for your applications, please react to the original post with 👍 (`+1`). If you would like to provide an additional use case for the feature, please post a comment.
+        
+
+        The team will review this feedback and make a final decision. Any decision will be posted on this thread, but please note that we may ultimately decide not to pursue this feature.
+
+
+        Thank you!
   dryRun: false
 
 noReply:

CHANGELOG.md

@@ -3,7 +3,8 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
-# [7.4.0](https://github.com/ionic-team/ionicons/compare/v7.3.0...v7.4.0) (2024-05-01)
+<<<<<<< HEAD
+# [7.4.0](https://github.com/ionic-team/ionicons/compare/v7.3.1...v7.4.0) (2024-05-01)
 
 
 ### Features
@@ -16,14 +17,12 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline
 
 
 
-# [7.4.0](https://github.com/ionic-team/ionicons/compare/v7.3.0...v7.4.0) (2024-05-01)
+## [7.3.1](https://github.com/ionic-team/ionicons/compare/v7.3.0...v7.3.1) (2024-03-27)
 
 
-### Features
+### Bug Fixes
 
-* add X logo ([#1371](https://github.com/ionic-team/ionicons/issues/1371)) ([0963fe2](https://github.com/ionic-team/ionicons/commit/0963fe20b77a03b0b8b7f4e94b646cd5d7b25f03)), closes [#1249](https://github.com/ionic-team/ionicons/issues/1249)
-* export setAssetPath ([#1372](https://github.com/ionic-team/ionicons/issues/1372)) ([87f2094](https://github.com/ionic-team/ionicons/commit/87f2094890c22b7b03bf754b6fd2651a83fe20ed)), closes [#1302](https://github.com/ionic-team/ionicons/issues/1302)
-* update server icon ([#1259](https://github.com/ionic-team/ionicons/issues/1259)) ([b4ade9d](https://github.com/ionic-team/ionicons/commit/b4ade9d887c0d5ecc29e25f8e12b576106de712a)), closes [#407](https://github.com/ionic-team/ionicons/issues/407)
+* filled ellipsis circle icons renders correctly ([#1353](https://github.com/ionic-team/ionicons/issues/1353)) ([63e60ec](https://github.com/ionic-team/ionicons/commit/63e60ec44c11bda5902b5a496113f65a5e6f3d85)), closes [#1320](https://github.com/ionic-team/ionicons/issues/1320)
 
 
 

package.json

@@ -1,6 +1,10 @@
 {
   "name": "ionicons",
+<<<<<<< HEAD
   "version": "7.4.0",
+=======
+  "version": "7.3.1",
+>>>>>>> origin/main
   "description": "Premium icons for Ionic.",
   "files": [
     "components/",
@@ -14,11 +18,12 @@
   "collection": "dist/collection/collection-manifest.json",
   "collection:main": "dist/collection/index.js",
   "scripts": {
-    "build": "tsc -p scripts/tsconfig.json && npm run build.files && npm run build.component && npm run collection.copy",
+    "compile.scripts": "tsc -p scripts/tsconfig.json",
+    "build": "npm run compile.scripts && npm run build.files && npm run build.component && npm run collection.copy",
     "build.files": "node scripts/build.js",
     "build.component": "stencil build",
     "collection.copy": "node scripts/collection-copy.js",
-    "start": "stencil build --dev --watch --serve",
+    "start": "npm run compile.scripts && npm run build.files && stencil build --dev --watch --serve",
     "test": "npm run test.spec",
     "test.spec": "stencil test --spec"
   },

readme.md

@@ -19,14 +19,15 @@ label.
 
 The Ionicons Web Component is an easy and performant way to use Ionicons in your app. The component will dynamically load an SVG for each icon, so your app is only requesting the icons that you need.
 
-Also note that only visible icons are loaded, and icons which are "below the fold" and hidden from the user's view do not make fetch requests for the svg resource.
+Also note that only visible icons are loaded, and icons that are "below the fold" and hidden from the user's view do not make fetch requests for the svg resource.
 
 ### Installation
 
-If you're using [Ionic Framework](https://ionicframework.com/), Ionicons is packaged by default, so no installation is necessary. Want to use Ionicons without Ionic Framework? Place the following `<script>` near the end of your page, right before the closing </body> tag, to enable them.
+If you're using [Ionic Framework](https://ionicframework.com/), Ionicons is packaged by default, so no installation is necessary. Want to use Ionicons without Ionic Framework? Place the following `<script>` near the end of your page, right before the closing `</body>` tag, to enable them.
 
 ```html
-<script src="https://unpkg.com/ionicons@latest/dist/ionicons.js"></script>
+<script type="module" src="https://cdn.jsdelivr.net/npm/ionicons@latest/dist/ionicons/ionicons.esm.js"></script>
+<script nomodule src="https://cdn.jsdelivr.net/npm/ionicons@latest/dist/ionicons/ionicons.js"></script>
 ```
 
 ### Basic usage
@@ -45,6 +46,24 @@ To use a custom SVG, provide its url in the `src` attribute to request the exter
 <ion-icon src="/path/to/external/file.svg"></ion-icon>
 ```
 
+#### Custom Asset Path
+
+If you have a different set of icons you would like to load or if the Ionicon icons are hosted on a different page or path, you can set the asset url from which Ionicons pulls the icons via:
+
+```ts
+import { setAssetPath } from '@stencil/core'
+
+// set root path for loading icons to "<root>/public/svg"
+setAssetPath(`${window.location.origin}/public/svg/`);
+```
+
+This allows the use of named icons like this:
+
+```html
+<!-- now pulls the svg from "<root>/public/svg/heart.svg" -->
+<ion-icon name="heart"></ion-icon>
+```
+
 ## Variants
 Each app icon in Ionicons has a `filled`, `outline` and `sharp` variant. These different variants are provided to make your app feel native to a variety of platforms. The filled variant uses the default name without a suffix. Note: Logo icons do not have outline or sharp variants.
 
@@ -55,7 +74,7 @@ Each app icon in Ionicons has a `filled`, `outline` and `sharp` variant. These d
 ```
 
 ### Platform specificity
-When using icons in Ionic Framework you can specify different icons per platform. Use the `md` and `ios` attributes and provide the platform specific icon/variant name.
+When using icons in Ionic Framework you can specify different icons per platform. Use the `md` and `ios` attributes and provide the platform-specific icon/variant name.
 
 ```html
 <ion-icon ios="heart-outline" md="heart-sharp"></ion-icon>

src/components/icon/icon.css

@@ -21,7 +21,6 @@
 }
 
 .ionicon-stroke-width {
-  stroke-width: 32px;
   stroke-width: var(--ionicon-stroke-width, 32px);
 }