$ionicScrollDelegate not working for ionic popups (ion-modal-view)

[jgw96]

From @ashutosh-akss on March 21, 2016 10:40

I am trying to resize modal view height after adding dynamic content.

I have given delegate-handle to my content

<ion-modal-view>
     <ion-content delegate-handle="create-post">

     </ion-content>
</ion-modal-view>

and then from my controller i am calling

$ionicScrollDelegate.$getByHandle('create-post').resize();

but it gives following error

ionic.bundle.js:21157 Delegate for handle "create-post" could not find a corresponding element with delegate-handle="create-post"! resize() was not called!
Possible cause: If you are calling resize() immediately, and your element with delegate-handle="create-post" is a child of your controller, then your element may not be compiled yet. Put a $timeout around your call to resize() and try again.

if i echo my $ionicScrollDelegate i get 3 instances.

this works for normal view.. any suggestions?

Thanks in advance

Cordova CLI: 6.0.0
Ionic CLI Version: 1.7.12
Ionic App Lib Version: 0.6.5
OS: Distributor ID: Ubuntu Description: Ubuntu 14.04.4 LTS
Node Version: v5.0.0

Copied from original issue: ionic-team/ionic-framework#5897

[jgw96]

From @leschirmeur on March 23, 2016 9:53

$ionicScrollDelegate.$getByHandle() does not work in modals. To circumvent this, we are using a custom scrollDelegate service instead of the default one from ionic which have have taken from ionic-team/ionic-framework#2754. Our service looks as follows:

// $ionicScrollDelegate not working for content in modals
// as described here: https://github.com/driftyco/ionic/issues/2754
// So using an intermediary service until it's fixed.
// Change to return standard and it should use native functionality.
angular
        .module('quiply')
        .service('QyScrollDelegate', QyScrollDelegate);

    /* @ngInject */
    function QyScrollDelegate($ionicScrollDelegate) {
        var custom = {
            $getByHandle: function(name) {
                var instances = $ionicScrollDelegate.$getByHandle(name)._instances;
                return instances.filter(function(element) {
                    return (element['$$delegateHandle'] == name);
                })[0];
            }
        };

        return custom;
    }

Then we are using it by injecting QyScrollDelegate first and then

QyScrollDelegate.$getByHandle('some-handle')

Hope this helps.

[jgw96]

From @ashutosh-akss on March 23, 2016 10:13

Thanks @leschirmeur , i will check this now

[Defcon0]

Any progress on that one? At least the fix in #157 (comment) works.