Skip to content
This repository was archived by the owner on May 4, 2022. It is now read-only.

Commit 7980ea8

Browse files
committed
chore(build): snapshot upgrades with more parameters
1 parent 71efd51 commit 7980ea8

File tree

7 files changed

+27
-18
lines changed

7 files changed

+27
-18
lines changed

config/demos/demos.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ module.exports = function(config) {
99
config = staticSite(config);
1010
config.set('buildConfig', require('../build.config'));
1111

12+
//rendering.outputFolder set by gulp task
13+
1214
config.merge('rendering.nunjucks.config.tags', {
1315
variableStart: '{$',
1416
variableEnd: '$}',
@@ -18,8 +20,6 @@ module.exports = function(config) {
1820

1921
config.set('logging.level', 'info');
2022

21-
config.set('rendering.outputFolder', path.resolve(projectBase, 'dist/ionic-demo'));
22-
2323
config.set('rendering.templateFolders', [
2424
path.resolve(__dirname, 'templates')
2525
]);

config/docs/docs.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ module.exports = function(config) {
1010

1111
config = basePackage(config);
1212

13+
//rendering.outputFolder set by gulp task
14+
1315
config.set('logging.level', 'info');
1416

1517
config.prepend('rendering.templateFolders', [
@@ -20,8 +22,6 @@ module.exports = function(config) {
2022
config.set('source.projectPath', '.');
2123

2224
config.set('versionFolderBase', 'docs');
23-
config.set('rendering.outputFolder', path.resolve(projectBase, 'dist/ionic-site'));
24-
//contentsFolder is set in the version-data processor
2525

2626
config.set('processing.api-docs', {
2727
outputPath: 'api/${docType}/${name}/index.md',

config/gulp-tasks/test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@ module.exports = function(gulp, argv) {
1717
*/
1818
var sauceInstance;
1919
gulp.task('sauce-connect', function(done) {
20-
gutil.log('sauce-connect parameters: ', _.pick(process.env, ['SAUCE_USER', 'SAUCE_KEY', 'SAUCE_TUNNEL_ID']));
20+
gutil.log('sauce-connect parameters: ', _.pick(process.env, ['SAUCE_USER', 'SAUCE_KEY', 'SAUCE_TUNNEL_ID', 'SAUCE_BUILD_ID']));
2121
require('sauce-connect-launcher')({
2222
username: process.env.SAUCE_USER,
2323
accessKey: process.env.SAUCE_KEY,
2424
tunnelIdentifier: process.env.SAUCE_TUNNEL_ID || 0,
25-
verbose: true
25+
// verbose: true
2626
}, function(err, instance) {
2727
if (err) return done('Failed to launch sauce connect!');
2828
sauceInstance = instance;
@@ -51,7 +51,7 @@ module.exports = function(gulp, argv) {
5151
karma.start(karmaConf, done);
5252
});
5353

54-
gulp.task('karm-sauce', ['run-karma-sauce'], sauceDisconnect);
54+
gulp.task('karma-sauce', ['run-karma-sauce'], sauceDisconnect);
5555
gulp.task('run-karma-sauce', ['sauce-connect'], function(done) {
5656
return karma.start(karmaSauceConf, done);
5757
});
@@ -66,7 +66,7 @@ module.exports = function(gulp, argv) {
6666
protractorHttpServer = http.createServer(app).listen(buildConfig.protractorPort);
6767
});
6868

69-
gulp.task('snapshot', ['snapshot-server'], function(done) {
69+
gulp.task('snapshot', ['protractor-server'], function(done) {
7070
snapshot(done, 'config/protractor.conf.js');
7171
});
7272

config/karma-sauce.conf.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ module.exports = _.assign({}, shared, {
1717
browserNoActivityTimeout: 60 * 1000,
1818
browserDisconnectTolerance: 2,
1919
browsers: [
20-
'sauce_ios',
20+
// 'sauce_ios',
2121
// 'sauce_safari',
22-
'sauce_android',
23-
// 'sauce_chrome',
22+
// 'sauce_android',
23+
'sauce_chrome',
2424
// 'sauce_firefox',
2525
// 'sauce_ie9',
2626
// 'sauce_ie10',
27-
// 'sauce_ie11'
27+
// 'sauce_ie11',
2828
],
2929
customLaunchers: {
3030
'sauce_ios': {

config/protractor-sauce.conf.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ exports.config = _.merge({}, config, {
1111
build: process.env.SAUCE_BUILD_ID || 1,
1212
'tunnel-identifier': process.env.SAUCE_TUNNEL_ID || 0,
1313
name: 'Ionic!',
14-
browserName: 'safari',
15-
platform: 'OS X 10.9'
14+
browserName: 'chrome'
1615
}
1716
});
1817

config/protractor.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ exports.config = {
44

55
// Spec patterns are relative to the location of the spec file. They may
66
// include glob patterns.
7-
specs: ['../dist/ionic-demo/nightly/**/*.scenario.js'],
7+
specs: [__dirname + '/../dist/ionic-demo/nightly/**/*.scenario.js'],
88

99
// Options to be passed to Jasmine-node.
1010
jasmineNodeOpts: {

gulpfile.js

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,10 @@ gulp.task('docs', function() {
6767

6868
var config = dgeni.loadConfig(path.join(__dirname, '/config/docs/docs.config.js'));
6969
config.set('currentVersion', docVersion);
70+
config.set(
71+
'rendering.outputFolder',
72+
argv.dist ? argv.dist : path.resolve(__dirname, buildConfig.dist, 'ionic-site')
73+
);
7074

7175
return dgeni.generator(config)().then(function() {
7276
gutil.log('Docs for', gutil.colors.cyan(docVersion), 'generated!');
@@ -82,14 +86,20 @@ gulp.task('demos', function(done) {
8286

8387
var config = dgeni.loadConfig(path.join(__dirname, '/config/demos/demos.config.js'));
8488
config.set('currentVersion', demoVersion);
89+
config.set('dist', buildConfig.dist);
90+
config.set(
91+
'rendering.outputFolder',
92+
argv.dist ? argv.dist : path.resolve(__dirname, buildConfig.dist, 'ionic-demo')
93+
);
8594

8695
dgeni.generator(config)().then(function() {
8796
gutil.log('Demos for', gutil.colors.cyan(demoVersion), 'generated!');
8897
gutil.log('Building ionic into demo folder...');
8998
cp.spawn('gulp', [
9099
'build',
91100
IS_RELEASE_BUILD ? '--release' : '--no-release',
92-
'--dist='+config.get('rendering.outputFolder')+'/'+config.get('rendering.contentsFolder')+'/ionic'
101+
'--dist=' + config.rendering.outputFolder + '/' +
102+
config.rendering.contentsFolder + '/ionic'
93103
])
94104
.on('exit', done);
95105
});
@@ -103,9 +113,9 @@ gulp.task('watch', ['build'], function() {
103113
});
104114

105115
gulp.task('changelog', function(done) {
106-
var newCodename = fs.readFileSync('config/CODENAMES').toString().split('\n')[0];
116+
var codename = pkg.codename;
107117
var file = argv.standalone ? '' : __dirname + '/CHANGELOG.md';
108-
var subtitle = argv.subtitle || '"' + newCodename + '"';
118+
var subtitle = argv.subtitle || '"' + codename + '"';
109119
var toHtml = !!argv.html;
110120
var dest = argv.dest || 'CHANGELOG.md';
111121
var from = argv.from;

0 commit comments

Comments
 (0)