Skip to content

Commit e9b8d69

Browse files
authored
fix(react): Fix React Typings (#176)
1 parent bcb8eac commit e9b8d69

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

packages/react/src/data-connect/index.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { ReservedQueryKeys } from "./types";
21

32
export {
43
DataConnectQueryClient,
@@ -12,4 +11,4 @@ export {
1211
useDataConnectMutation,
1312
type useDataConnectMutationOptions,
1413
} from "./useDataConnectMutation";
15-
export type { FlattenedQueryResult, FlattenedMutationResult } from "./types";
14+
export type { QueryResultRequiredRef, UseDataConnectMutationResult, UseDataConnectQueryResult } from "./types";

packages/react/src/data-connect/query-client.ts

+5-6
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,12 @@ import {
99
type QueryResult,
1010
executeQuery,
1111
} from "firebase/data-connect";
12-
import type { FlattenedQueryResult } from "./types";
1312

1413
export type DataConnectQueryOptions<Data, Variables> = Omit<
1514
FetchQueryOptions<
16-
FlattenedQueryResult<Data, Variables>,
15+
Data,
1716
FirebaseError,
18-
FlattenedQueryResult<Data, Variables>,
17+
Data,
1918
QueryKey
2019
>,
2120
"queryFn" | "queryKey"
@@ -30,7 +29,7 @@ export class DataConnectQueryClient extends QueryClient {
3029
options?: DataConnectQueryOptions<Data, Variables>,
3130
) {
3231
let queryRef: QueryRef<Data, Variables>;
33-
let initialData: FlattenedQueryResult<Data, Variables> | undefined;
32+
let initialData: Data | undefined;
3433

3534
if ("ref" in refOrResult) {
3635
queryRef = refOrResult.ref;
@@ -45,9 +44,9 @@ export class DataConnectQueryClient extends QueryClient {
4544
}
4645

4746
return this.prefetchQuery<
48-
FlattenedQueryResult<Data, Variables>,
47+
Data,
4948
FirebaseError,
50-
FlattenedQueryResult<Data, Variables>,
49+
Data,
5150
QueryKey
5251
>({
5352
...options,

packages/react/src/data-connect/useDataConnectQuery.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
import type { PartialBy } from "../../utils";
1111
import {
1212
QueryResultRequiredRef,
13-
UseDataConnectQuery,
13+
UseDataConnectQueryResult,
1414
} from "./types";
1515
import { useState } from "react";
1616

@@ -26,7 +26,7 @@ export function useDataConnectQuery<Data = unknown, Variables = unknown>(
2626
FirebaseError
2727
>,
2828
_callerSdkType: CallerSdkType = CallerSdkTypeEnum.TanstackReactCore
29-
): UseDataConnectQuery<Data, Variables> {
29+
): UseDataConnectQueryResult<Data, Variables> {
3030
const [dataConnectResult, setDataConnectResult] = useState<QueryResultRequiredRef<Data, Variables>>('ref' in refOrResult ? refOrResult : { ref: refOrResult });
3131
let initialData: Data | undefined;
3232
const { ref } = dataConnectResult;

0 commit comments

Comments
 (0)