Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Sign-In without client secret #25

Open
aemelyanovff opened this issue Jun 16, 2022 · 1 comment
Open

GitHub Sign-In without client secret #25

aemelyanovff opened this issue Jun 16, 2022 · 1 comment

Comments

@aemelyanovff
Copy link

GitHub signin requires client secret. But including secrets in desktop apps is not safe, is it? An attacker can decompile the app and find the secret.

How do Google Signin and Facebook Signin work fine without asking client secret? Can the same be done for GitHub?
This was referenced Jun 21, 2022
Merged
Merged
@pr-Mais
Copy link
Member

pr-Mais commented Jun 22, 2022

Thank you for pointing it out!
That's right, we're investigating the same issue in FlutterFire on iOS and Android, see linked PRs.
I will explore how to get FlutterFire Desktop to support GitHub provider without a secret as well, since it's the plugin behavior on mobile platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pr-Mais @aemelyanovff