Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests: fixing comments notifications for record requests #1903

Open
slint opened this issue Dec 9, 2024 · 0 comments · Fixed by #1904 or inveniosoftware/invenio-app-rdm#2939
Open

Comments

@slint
Copy link
Member

slint commented Dec 9, 2024

Update: these were implemented, merged, and released, but then reverted, since they are backwards incompatible. Options for next steps:


Request comments on draft review and record inclusion requests are not working because the recipients can be communities, that the base comment notification builder cannot resolve to specific user email recipients.

The default set of community recipients should be curators, managers, and owners (since they're the that have permissions to accept/reject record-related requests).

(Note, see how a similar fix was applied at inveniosoftware/invenio-communities#1256)

@slint slint converted this from a draft issue Dec 9, 2024
@slint slint changed the title requests: fixing comments notifications for member and record requests requests: fixing comments notifications for record requests Dec 9, 2024
@carlinmack carlinmack moved this from In progress to In review 🔎 in Sprint Q1/2025 Dec 11, 2024
@carlinmack carlinmack removed their assignment Dec 11, 2024
@slint slint moved this from In review 🔍 to To release 🤖 in Sprint Q1/2025 Jan 14, 2025
@slint slint moved this from To release 🤖 to Released ✔️ in Sprint Q1/2025 Jan 16, 2025
@slint slint moved this from Released ✔️ to In progress in Sprint Q1/2025 Jan 16, 2025
@slint slint moved this from In progress to Ready in Sprint Q1/2025 Jan 22, 2025
@carlinmack carlinmack moved this from Ready to To release 🤖 in Sprint Q1/2025 Jan 23, 2025
@carlinmack carlinmack moved this from To release 🤖 to Released ✔️ in Sprint Q1/2025 Jan 23, 2025
@carlinmack carlinmack moved this from Released ✔️ to To release 🤖 in Sprint Q1/2025 Jan 27, 2025
@slint slint moved this from To release 🤖 to Ready in Sprint Q1/2025 Mar 3, 2025
@slint slint reopened this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
2 participants