Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readyness_check config variable placement #4

Open
ppanero opened this issue Aug 26, 2020 · 0 comments
Open

readyness_check config variable placement #4

ppanero opened this issue Aug 26, 2020 · 0 comments
Labels
question Further information is requested

Comments

@ppanero
Copy link
Member

ppanero commented Aug 26, 2020

The following snippet is placed in services.py:

READYNESS_CHECKS = {
    "es": es_healthcheck,
    "postgresql": postgresql_healthcheck,
    "mysql": mysql_healthcheck,
    "redis": redis_healthcheck,
}
"""Readyness check functions module path, as string."""

However the rest of the configuration is placed in config.py. Should this be moved to config.py?
It might not trivial due to possible circular dependencies and importing a string is not trivial without depending on invenio-base.utils or duplicating the loading code. Moreover, there is no logic to allow the user to overwrite configuration with a provided config.py therefore having the configuration separated around files does not pose a problem.

@ppanero ppanero added the question Further information is requested label Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant