Expand Tests and remove some redundant clone's (#617)

* fix(errors): make error msesages consisten with each other

* test(rate-limit-service): add tests

* test(balance-service): add tests to balance service

* test(max-packet-service): add tests to max packet amount service

* test(redis): make redis tests more clear and verbose

* fix(redis): remove a bunch of redundant clone operations

Author: gakonst

Cargo.lock

@@ -65,7 +65,7 @@ where
         + Sync
         + 'static,
 {
-    // TODO can we make any of the Filters const or put them in lazy_static?
+    // TODO can we make any of the Filters const or put them in once_cell?
     let with_store = warp::any().map(move || store.clone()).boxed();
     let with_incoming_handler = warp::any().map(move || incoming_handler.clone()).boxed();
 

crates/interledger-api/src/routes/accounts.rs

@@ -9,9 +9,9 @@ use thiserror::Error;
 pub enum AccountStoreError {
     #[error("{0}")]
     Other(#[from] Box<dyn StdError + Send + 'static>),
-    #[error("account with username/id `{0}` was not found")]
+    #[error("account `{0}` was not found")]
     AccountNotFound(String),
-    #[error("account with id `{0}` already exists")]
+    #[error("account `{0}` already exists")]
     AccountExists(String),
     #[error("wrong account length (expected {expected}, got {actual})")]
     WrongLength { expected: usize, actual: usize },

crates/interledger-errors/src/account_store_error.rs

@@ -8,9 +8,9 @@ use thiserror::Error;
 pub enum BtpStoreError {
     #[error("{0}")]
     Other(#[from] Box<dyn StdError + Send + 'static>),
-    #[error("account with username/id `{0}` was not found")]
+    #[error("account `{0}` was not found")]
     AccountNotFound(String),
-    #[error("account with id `{0}` is not authorized for this action")]
+    #[error("account `{0}` is not authorized for this action")]
     Unauthorized(String),
 }
 

crates/interledger-errors/src/btp_store_error.rs

@@ -16,8 +16,10 @@ pub enum CreateAccountError {
     InvalidHttpUrl(UrlParseError),
     #[error("the provided btp url is not valid: {0}")]
     InvalidBtpUrl(UrlParseError),
-    #[error("the provided routing relation not valid: {0}")]
+    #[error("the provided routing relation is not valid: {0}")]
     InvalidRoutingRelation(String),
+    #[error("the provided value for parameter `{0}` was too large")]
+    ParamTooLarge(String),
 }
 
 impl From<CreateAccountError> for ApiError {

crates/interledger-errors/src/create_account_error.rs

@@ -8,9 +8,9 @@ use thiserror::Error;
 pub enum HttpStoreError {
     #[error("{0}")]
     Other(#[from] Box<dyn StdError + Send + 'static>),
-    #[error("account with username/id `{0}` was not found")]
+    #[error("account `{0}` was not found")]
     AccountNotFound(String),
-    #[error("account with id `{0}` is not authorized for this action")]
+    #[error("account `{0}` is not authorized for this action")]
     Unauthorized(String),
 }
 

crates/interledger-errors/src/http_store_error.rs

@@ -11,9 +11,9 @@ pub enum NodeStoreError {
     Other(#[from] Box<dyn StdError + Send + 'static>),
     #[error("Settlement engine URL loaded was not a valid url: {0}")]
     InvalidEngineUrl(String),
-    #[error("account with username/id `{0}` was not found")]
+    #[error("account `{0}` was not found")]
     AccountNotFound(String),
-    #[error("account with id `{0}` already exists")]
+    #[error("account `{0}` already exists")]
     AccountExists(String),
     #[error("not all of the given accounts exist")]
     MissingAccounts,

crates/interledger-errors/src/node_store_error.rs

@@ -30,3 +30,7 @@ uuid = "0.8.1"
 [dev-dependencies]
 uuid = { version = "0.8.1", default-features = false}
 bytes04 = { package = "bytes", version = "0.4", default-features = false }
+once_cell = "1.3.1"
+parking_lot = "0.10.0"
+mockito = "0.23.0"
+url = "2.1.0"