Skip to content

Commit b4373c7

Browse files
committed
Make code scan more robust
This CI check fails if `cargo clippy` fails, which is unfortunate since we really want the output of `cargo clippy`, errors and all, available to the CodeQL action. This change attempts to remedy that by ignoring any error code returned by `cargo clippy` (and only `cargo clippy`; we expect the other steps to succeed.
1 parent b4587a1 commit b4373c7

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

.github/workflows/scan.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,9 @@ jobs:
3636

3737
- name: Run clippy
3838
run: |
39-
cargo clippy --features openvino-sys/runtime-linking --message-format=json > clippy.json
39+
cargo clippy --features openvino-sys/runtime-linking --message-format=json > clippy.json || true
4040
clippy-sarif --input clippy.json --output clippy.sarif
4141
sarif-fmt --input clippy.sarif
42-
continue-on-error: true
4342
4443
- name: Upload analysis
4544
uses: github/codeql-action/upload-sarif@5618c9fc1e675841ca52c1c6b1304f5255a905a0 # v2.19.0

0 commit comments

Comments
 (0)