Skip to content

Commit f4b2d3a

Browse files
authored
Upgrade emsdk to 3.1.3 (microsoft#10577)
1 parent c51b500 commit f4b2d3a

File tree

6 files changed

+18
-4
lines changed

6 files changed

+18
-4
lines changed

.gitmodules

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
[submodule "cmake/external/emsdk"]
6363
path = cmake/external/emsdk
6464
url = https://github.com/emscripten-core/emsdk.git
65-
branch = 2.0.34
65+
branch = 3.1.3
6666
[submodule "cmake/external/onnxruntime-extensions"]
6767
path = cmake/external/onnxruntime-extensions
6868
url = https://github.com/microsoft/onnxruntime-extensions.git

include/onnxruntime/core/common/eigen_common_wrapper.h

+9
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,15 @@
2525
#ifdef HAS_CLASS_MEMACCESS
2626
#pragma GCC diagnostic ignored "-Wclass-memaccess"
2727
#endif
28+
29+
// cmake/external/eigen\Eigen/src/Core/util/Meta.h:454:25:
30+
// error: 'result_of<Eigen::internal::scalar_product_op<unsigned long long> (const unsigned long long &, const unsigned long long &)>'
31+
// is deprecated [-Werror,-Wdeprecated-declarations]
32+
// typedef typename std::result_of<T>::type type1;
33+
#ifdef HAS_DEPRECATED_DECLARATIONS
34+
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
35+
#endif
36+
2837
#elif defined(_MSC_VER)
2938
// build\windows\debug\external\eigen3\unsupported\eigen\cxx11\src/Tensor/Tensor.h(76):
3039
// warning C4554: '&': check operator precedence for possible error; use parentheses to clarify precedence

onnxruntime/core/util/math_cpuonly.h

+5
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,11 @@
4242
#ifdef HAS_CLASS_MEMACCESS
4343
#pragma GCC diagnostic ignored "-Wclass-memaccess"
4444
#endif
45+
46+
#ifdef HAS_DEPRECATED_DECLARATIONS
47+
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
48+
#endif
49+
4550
#elif defined(_MSC_VER)
4651
// build\windows\debug\external\eigen3\unsupported\eigen\cxx11\src/Tensor/Tensor.h(76):
4752
// warning C4554: '&': check operator precedence for possible error; use parentheses to clarify precedence

tools/ci_build/build.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ def convert_arg_line_to_args(self, arg_line):
376376
parser.add_argument(
377377
"--wasm_malloc", default="dlmalloc", help="Specify memory allocator for WebAssembly")
378378
parser.add_argument(
379-
"--emsdk_version", default="2.0.34", help="Specify version of emsdk")
379+
"--emsdk_version", default="3.1.3", help="Specify version of emsdk")
380380

381381
# Enable onnxruntime-extensions
382382
parser.add_argument(

tools/ci_build/github/azure-pipelines/templates/win-wasm-ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
variables:
1919
EnvSetupScript: setup_env.bat
2020
buildArch: x64
21-
CommonBuildArgs: '--config ${{ parameters.BuildConfig }} --skip_submodule_sync --cmake_generator "Visual Studio 16 2019" --build_wasm --emsdk_version releases-upstream-823d37b15d1ab61bc9ac0665ceef6951d3703842-64bit ${{ parameters.ExtraBuildArgs }}'
21+
CommonBuildArgs: '--config ${{ parameters.BuildConfig }} --skip_submodule_sync --cmake_generator "Visual Studio 16 2019" --build_wasm --emsdk_version releases-upstream-2ddc66235392b37e5b33477fd86cbe01a14b8aa2-64bit ${{ parameters.ExtraBuildArgs }}'
2222
timeoutInMinutes: 120
2323
workspace:
2424
clean: all

0 commit comments

Comments
 (0)