Revert "enable RemoveUnusedIdImplicitArguments by default"

pkwasnie-intel · igcbot · commit f8b61ace8858 · 2025-04-09T19:15:23.000+02:00
This reverts commit 979782a.
diff --git a/IGC/Compiler/CISACodeGen/ShaderCodeGen.cpp b/IGC/Compiler/CISACodeGen/ShaderCodeGen.cpp
@@ -780,14 +780,13 @@ void AddLegalizationPasses(CodeGenContext& ctx, IGCPassManager& mpm, PSSignature
     }
 
     if (ctx.type == ShaderType::OPENCL_SHADER &&
-        static_cast<OpenCLProgramContext&>(ctx).m_InternalOptions.PromoteStatelessToBindless &&
-        !ctx.getModuleMetaData()->compOpt.GreaterThan4GBBufferRequired)
+        static_cast<OpenCLProgramContext&>(ctx).m_InternalOptions.PromoteStatelessToBindless)
     {
         if (static_cast<OpenCLProgramContext&>(ctx).m_InternalOptions.UseBindlessLegacyMode)
         {
             mpm.add(new PromoteStatelessToBindless());
         }
-        else if (!isOptDisabled)
+        else if (!ctx.getModuleMetaData()->compOpt.GreaterThan4GBBufferRequired && !isOptDisabled)
         {
             // Advanced bindless mode used by the regular OpenCL compilation path
             mpm.add(new StatelessToStateful(TargetAddressing::BINDLESS));

Original file line number	Diff line number	Diff line change
`@@ -780,14 +780,13 @@ void AddLegalizationPasses(CodeGenContext& ctx, IGCPassManager& mpm, PSSignature`
`780`	`780`	`}`
`781`	`781`
`782`	`782`	`if (ctx.type == ShaderType::OPENCL_SHADER &&`
`783`		`- static_cast<OpenCLProgramContext&>(ctx).m_InternalOptions.PromoteStatelessToBindless &&`
`784`		`- !ctx.getModuleMetaData()->compOpt.GreaterThan4GBBufferRequired)`
	`783`	`+ static_cast<OpenCLProgramContext&>(ctx).m_InternalOptions.PromoteStatelessToBindless)`
`785`	`784`	`{`
`786`	`785`	`if (static_cast<OpenCLProgramContext&>(ctx).m_InternalOptions.UseBindlessLegacyMode)`
`787`	`786`	`{`
`788`	`787`	`mpm.add(new PromoteStatelessToBindless());`
`789`	`788`	`}`
`790`		`- else if (!isOptDisabled)`
	`789`	`+ else if (!ctx.getModuleMetaData()->compOpt.GreaterThan4GBBufferRequired && !isOptDisabled)`
`791`	`790`	`{`
`792`	`791`	`// Advanced bindless mode used by the regular OpenCL compilation path`
`793`	`792`	`mpm.add(new StatelessToStateful(TargetAddressing::BINDLESS));`