Remove redundant guard for a pattern of global imm offsets

krystian-andrzejewski · igcbot · commit 33a954cf513f · 2025-07-22T15:53:34.000+02:00
This simplifies the control flow for a pattern of global imm offsets.
diff --git a/IGC/Compiler/CISACodeGen/PatternMatchPass.cpp b/IGC/Compiler/CISACodeGen/PatternMatchPass.cpp
@@ -2418,9 +2418,6 @@ bool CodeGenPatternMatch::MatchImmOffsetLSC(llvm::Instruction &I) {
 
     llvm::Value *varOffset = isConstant0 ? addSubInst->getOperand(1) : addSubInst->getOperand(0);
 
-    if (!isA64AddressingModel && m_ctx->type != ShaderType::OPENCL_SHADER && IGC_GET_FLAG_VALUE(LscImmOffsMatch) < 2)
-      return false;
-
     // HW does an early bounds check on varOffset for A32 messages. Thus, if varOffset
     // is negative, then the bounds check fails early even though the immediate offset
     // would bring the final calculation to a positive number.
diff --git a/IGC/Compiler/tests/EmitVISAPass/fold-immediates.ll b/IGC/Compiler/tests/EmitVISAPass/fold-immediates.ll
@@ -5,8 +5,7 @@
 ; SPDX-License-Identifier: MIT
 ;
 ;============================ end_copyright_notice =============================
-
-; REQUIRES: temporarily-disabled, regkeys
+; REQUIRES: regkeys
 ;
 ; RUN: igc_opt -platformbmg -igc-emit-visa %s -dx12 -inputcs -regkey DumpVISAASMToConsole | FileCheck %s
 ; ------------------------------------------------

Original file line number	Diff line number	Diff line change
`@@ -5,8 +5,7 @@`
`5`	`5`	`; SPDX-License-Identifier: MIT`
`6`	`6`	`;`
`7`	`7`	`;============================ end_copyright_notice =============================`
`8`		`-`
`9`		`-; REQUIRES: temporarily-disabled, regkeys`
	`8`	`+; REQUIRES: regkeys`
`10`	`9`	`;`
`11`	`10`	`; RUN: igc_opt -platformbmg -igc-emit-visa %s -dx12 -inputcs -regkey DumpVISAASMToConsole \| FileCheck %s`
`12`	`11`	`; ------------------------------------------------`