Prepare VISA for C++20

Prepare VISA for C++20

Author: jaladreips

visa/CISA.l

@@ -197,8 +197,9 @@ void resetGlobalVariables() {
 ".input"            {TRACE("** INPUT"); return DIRECTIVE_INPUT;}
 "."implicit[a-zA-Z0-9_\-$@?]* {
         TRACE("**  DIRECTIVE_IMPLICIT");
-        CISAlval.string = strdup(yytext);
-        CISAlval.string[yyleng] = '\0';
+        char* yytext_dup = strdup(yytext);
+        yytext_dup[yyleng] = '\0';
+        CISAlval.string = yytext_dup;
         return DIRECTIVE_IMPLICIT;
     }
 ".function"         {TRACE("** FUNCTION"); return DIRECTIVE_FUNC;}
@@ -877,8 +878,9 @@ lifetime"."end {
 
 ^[a-zA-Z_$@?][a-zA-Z0-9_\-$@?]*: {
         TRACE("**  LABEL");
-        CISAlval.string = strdup(yytext);
-        CISAlval.string[yyleng - 1] = '\0';
+        char* yytext_dup = strdup(yytext);
+        yytext_dup[yyleng - 1] = '\0';
+        CISAlval.string = yytext_dup;
         return LABEL;
     }
 

visa/CISA.y

@@ -89,7 +89,7 @@ std::vector<attr_gen_struct*> AttrOptVar;
         char *    decoded;
         size_t    len;
     } strlit;
-    char *                 string;
+    const char *           string;
 
     VISA_Type              type;
     ISA_Opcode             opcode;
@@ -149,7 +149,7 @@ std::vector<attr_gen_struct*> AttrOptVar;
     } regAccess;
 
     struct {
-        char *             aliasname;
+        const char *       aliasname;
         int                offset;
     } alias;
 
@@ -251,7 +251,7 @@ std::vector<attr_gen_struct*> AttrOptVar;
         int                    surfaceIndex;
     } lsc_addr_model;
     struct sampler_base_struct {
-        char                  *base;
+        const char            *base;
         unsigned int          offset;
     } sampler_base;
 

visa/G4_Operand.h

@@ -562,7 +562,7 @@ class G4_SrcRegRegion final : public G4_Operand {
   G4_SrcRegRegion& operator=(const G4_SrcRegRegion&) = delete;
   void *operator new(size_t sz, Mem_Manager &m) { return m.alloc(sz); }
 
-  bool operator==(const G4_SrcRegRegion &other) {
+  bool operator==(const G4_SrcRegRegion &other) const {
     if (base != other.base || regOff != other.regOff ||
         subRegOff != other.subRegOff ||
         desc->vertStride != other.desc->vertStride ||