You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For better usability, I suggest replacing all: "lib" with ${CMAKE_INSTALL_LIBDIR} and "include" with ${CMAKE_INSTALL_INCLUDEDIR}
Reason is similar to above suggestion - some customization when building ipp-crypto within another project could make it a lot easier to maintain project codes and build paths.
Please let me know what you think.
The text was updated successfully, but these errors were encountered:
For better cmake usability, I would like to suggest two changes in the ipp-crypto cmake configuration.
Replace all
CMAKE_BINARY_DIR
For ipp-crypto standalone build, this may not cause any issue, but when building ipp-crypto with cmake
FetchContent
, within another project, it will pollute thebuild
folder of the project with several package files, generated from:https://github.com/intel/ipp-crypto/blob/46944bd18e6dbad491ef9b9a3404303ef7680c09/sources/cmake/ippcp-gen-pkg-config.cmake#L42-L45
https://github.com/intel/ipp-crypto/blob/46944bd18e6dbad491ef9b9a3404303ef7680c09/sources/cmake/ippcp-gen-pkg-config.cmake#L49
https://github.com/intel/ipp-crypto/blob/46944bd18e6dbad491ef9b9a3404303ef7680c09/sources/cmake/ippcp-gen-pkg-config.cmake#L65-L70
It would be cleaner and provide better usage if all
CMAKE_BINARY_DIR
could be replaced withPROJECT_BINARY_DIR
orCMAKE_CURRENT_BINARY_DIR
.Use
GNUInstallDirs
variables for installationThe current installation destination for headers and libraries are using constant strings:
https://github.com/intel/ipp-crypto/blob/46944bd18e6dbad491ef9b9a3404303ef7680c09/sources/ippcp/CMakeLists.txt#L483-L486
https://github.com/intel/ipp-crypto/blob/46944bd18e6dbad491ef9b9a3404303ef7680c09/sources/ippcp/crypto_mb/src/CMakeLists.txt#L121-L131
For better usability, I suggest replacing all:
"lib"
with${CMAKE_INSTALL_LIBDIR}
and"include"
with${CMAKE_INSTALL_INCLUDEDIR}
Reason is similar to above suggestion - some customization when building ipp-crypto within another project could make it a lot easier to maintain project codes and build paths.
Please let me know what you think.
The text was updated successfully, but these errors were encountered: