Skip to content

Commit 4cb6bbd

Browse files
fix: cl_intel_subgroup_split_matrix_multiply_accumulate support on PVC
Related-To: GSD-7696 Signed-off-by: Dunajski, Bartosz <[email protected]> Source: 3a5e6c0
1 parent 93ad115 commit 4cb6bbd

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

opencl/test/unit_test/xe_hpc_core/pvc/cl_gfx_core_helper_tests_pvc.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ PVCTEST_F(ClGfxCoreHelperTestsPvcXt, givenRelease1261WhenAskingForDeviceFeatures
6565
std::string extensions = compilerHelper.getDeviceExtensions(*deviceHwInfo, rootEnv->releaseHelper.get());
6666

6767
EXPECT_EQ(std::string::npos, extensions.find("cl_intel_subgroup_matrix_multiply_accumulate"));
68+
EXPECT_EQ(std::string::npos, extensions.find("cl_intel_subgroup_split_matrix_multiply_accumulate"));
6869
}
6970

7071
} // namespace NEO

opencl/test/unit_test/xe_hpc_core/test_cl_device_caps_xe_hpc_core.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (C) 2022-2023 Intel Corporation
2+
* Copyright (C) 2022-2024 Intel Corporation
33
*
44
* SPDX-License-Identifier: MIT
55
*
@@ -22,7 +22,7 @@ XE_HPC_CORETEST_F(XeHpcCoreClDeviceCaps, givenXeHpcCoreWhenCheckExtensionsThenDe
2222

2323
EXPECT_TRUE(hasSubstr(caps.deviceExtensions, std::string("cl_khr_subgroups")));
2424
EXPECT_TRUE(hasSubstr(caps.deviceExtensions, std::string("cl_intel_subgroup_matrix_multiply_accumulate")));
25-
EXPECT_TRUE(hasSubstr(caps.deviceExtensions, std::string("cl_intel_subgroup_split_matrix_multiply_accumulate")));
25+
EXPECT_FALSE(hasSubstr(caps.deviceExtensions, std::string("cl_intel_subgroup_split_matrix_multiply_accumulate")));
2626
EXPECT_TRUE(hasSubstr(caps.deviceExtensions, std::string("cl_intel_bfloat16_conversions")));
2727
}
2828

shared/source/xe_hpc_core/enable_compiler_product_helper_pvc.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,6 @@ bool CompilerProductHelperHw<IGFX_PVC>::isMatrixMultiplyAccumulateSupported(cons
7777
return true;
7878
}
7979

80-
template <>
81-
bool CompilerProductHelperHw<IGFX_PVC>::isSplitMatrixMultiplyAccumulateSupported(const ReleaseHelper *releaseHelper) const {
82-
return true;
83-
}
84-
8580
template <>
8681
bool CompilerProductHelperHw<IGFX_PVC>::isBFloat16ConversionSupported(const ReleaseHelper *releaseHelper) const {
8782
return true;

shared/test/unit_test/helpers/compiler_product_helper_tests.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (C) 2021-2023 Intel Corporation
2+
* Copyright (C) 2021-2024 Intel Corporation
33
*
44
* SPDX-License-Identifier: MIT
55
*
@@ -180,11 +180,11 @@ HWTEST2_F(CompilerProductHelperFixture, GivenReleaseHelperThenSplitMatrixMultipl
180180
}
181181
}
182182

183-
HWTEST2_F(CompilerProductHelperFixture, GivenReleaseHelperThenSplitMatrixMultiplyAccumulateIsSupported, IsXeHpcCore) {
183+
HWTEST2_F(CompilerProductHelperFixture, GivenReleaseHelperThenSplitMatrixMultiplyAccumulateIsNotSupported, IsXeHpcCore) {
184184
auto &compilerProductHelper = pDevice->getCompilerProductHelper();
185185
auto releaseHelper = pDevice->getReleaseHelper();
186186

187-
EXPECT_TRUE(compilerProductHelper.isSplitMatrixMultiplyAccumulateSupported(releaseHelper));
187+
EXPECT_FALSE(compilerProductHelper.isSplitMatrixMultiplyAccumulateSupported(releaseHelper));
188188
}
189189

190190
HWTEST2_F(CompilerProductHelperFixture, givenAotConfigWhenSetHwInfoRevisionIdThenCorrectValueIsSet, IsAtMostDg2) {

0 commit comments

Comments
 (0)