Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Spotbug warnings #74

Open
iperdomo opened this issue May 18, 2023 · 0 comments
Open

Fix Spotbug warnings #74

iperdomo opened this issue May 18, 2023 · 0 comments
Assignees
@iperdomo
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@iperdomo
Copy link
Collaborator

Spotbugs is a static analysis tool that suggests fixes to common programming pitfalls, .e.g. Strings are immutable in Java, using == instead of .equals() when comparing objects, etc.
@iperdomo iperdomo self-assigned this May 18, 2023
iperdomo added a commit that referenced this issue May 18, 2023
@iperdomo
[#74] String.replaceAll() called with "." as regex
6cee006 
System.out.println(".klab.".replaceAll(".", "_"));   // ______
System.out.println(".klab.".replaceAll("\\.", "_")); // _klab_
iperdomo added a commit that referenced this issue May 18, 2023
@iperdomo
[#74] Double conditional check
16809e8 
- The same check done twice
iperdomo added a commit that referenced this issue May 18, 2023
@iperdomo
[#74] Unused locals, double conditionals
f49b852 
- Deleted code, debugged code
@iperdomo iperdomo added the good first issue Good for newcomers label Nov 30, 2023
@iperdomo iperdomo added the help wanted Extra attention is needed label Jan 11, 2024
iperdomo added a commit that referenced this issue Apr 18, 2024
@iperdomo
[#74] Use synchronized to initialize static field
7af7801
iperdomo added a commit that referenced this issue Apr 18, 2024
@iperdomo
[#74] Use .equals() when comparing strings
c20f91a
iperdomo added a commit that referenced this issue Apr 18, 2024
@iperdomo
[#74] Remove instance property
b8712ff 
This member "shadows" the `protected` property of the superclass
iperdomo added a commit that referenced this issue Apr 18, 2024
@iperdomo
[#74] Removes unused local variable
d682994
iperdomo added a commit that referenced this issue Apr 18, 2024
@iperdomo
[#74] Use .equals() when comparing objects
0bfceee 
There is a `long` and a `Long` member in this class. The method is
comparing the object not the primitive
iperdomo added a commit that referenced this issue Apr 18, 2024
@iperdomo
[#74] Remove unused classes
d57afcf 
SpotBugs warned about discaring the return value of
`String.format()`. After checking the codebase it seems that we're not
using these classes.
iperdomo added a commit that referenced this issue Apr 18, 2024
@iperdomo
[#74] Missing break
95e5fec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iperdomo iperdomo

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iperdomo