Skip to content

Commit 764ded0

Browse files
GSVarshaFerenc-
authored andcommitted
boto3: remove explicit credential mocking
Signed-off-by: Varsha GS <[email protected]>
1 parent 360c808 commit 764ded0

File tree

3 files changed

+0
-48
lines changed

3 files changed

+0
-48
lines changed

tests/clients/boto3/test_boto3_s3.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -22,33 +22,17 @@
2222

2323

2424
class TestS3(unittest.TestCase):
25-
def set_aws_credentials(self):
26-
""" Mocked AWS Credentials for moto """
27-
for variable_name in self.variable_names:
28-
os.environ[variable_name] = "testing"
29-
3025
def setUp(self):
3126
""" Clear all spans before a test run """
3227
self.recorder = tracer.recorder
3328
self.recorder.clear_spans()
34-
self.variable_names = (
35-
"AWS_ACCESS_KEY_ID", "AWS_SECRET_ACCESS_KEY",
36-
"AWS_SECURITY_TOKEN", "AWS_SESSION_TOKEN"
37-
)
38-
self.set_aws_credentials()
3929
self.mock = mock_aws()
4030
self.mock.start()
4131
self.s3 = boto3.client('s3', region_name='us-east-1')
4232

43-
def unset_aws_credentials(self):
44-
""" Reset all environment variables of consequence """
45-
for variable_name in self.variable_names:
46-
os.environ.pop(variable_name, None)
47-
4833
def tearDown(self):
4934
# Stop Moto after each test
5035
self.mock.stop()
51-
self.unset_aws_credentials()
5236

5337

5438
def test_vanilla_create_bucket(self):

tests/clients/boto3/test_boto3_ses.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -20,33 +20,17 @@
2020
pwd = os.path.dirname(os.path.abspath(__file__))
2121

2222
class TestSes(unittest.TestCase):
23-
def set_aws_credentials(self):
24-
""" Mocked AWS Credentials for moto """
25-
for variable_name in self.variable_names:
26-
os.environ[variable_name] = "testing"
27-
2823
def setUp(self):
2924
""" Clear all spans before a test run """
3025
self.recorder = tracer.recorder
3126
self.recorder.clear_spans()
32-
self.variable_names = (
33-
"AWS_ACCESS_KEY_ID", "AWS_SECRET_ACCESS_KEY",
34-
"AWS_SECURITY_TOKEN", "AWS_SESSION_TOKEN"
35-
)
36-
self.set_aws_credentials()
3727
self.mock = mock_aws()
3828
self.mock.start()
3929
self.ses = boto3.client('ses', region_name='us-east-1')
4030

41-
def unset_aws_credentials(self):
42-
""" Reset all environment variables of consequence """
43-
for variable_name in self.variable_names:
44-
os.environ.pop(variable_name, None)
45-
4631
def tearDown(self):
4732
# Stop Moto after each test
4833
self.mock.stop()
49-
self.unset_aws_credentials()
5034

5135

5236
def test_vanilla_verify_email(self):

tests/clients/boto3/test_boto3_sqs.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -23,34 +23,18 @@
2323

2424

2525
class TestSqs(unittest.TestCase):
26-
def set_aws_credentials(self):
27-
""" Mocked AWS Credentials for moto """
28-
for variable_name in self.variable_names:
29-
os.environ[variable_name] = "testing"
30-
3126
def setUp(self):
3227
""" Clear all spans before a test run """
3328
self.recorder = tracer.recorder
3429
self.recorder.clear_spans()
35-
self.variable_names = (
36-
"AWS_ACCESS_KEY_ID", "AWS_SECRET_ACCESS_KEY",
37-
"AWS_SECURITY_TOKEN", "AWS_SESSION_TOKEN"
38-
)
39-
self.set_aws_credentials()
4030
self.mock = mock_aws()
4131
self.mock.start()
4232
self.sqs = boto3.client('sqs', region_name='us-east-1')
4333
self.http_client = urllib3.PoolManager()
4434

45-
def unset_aws_credentials(self):
46-
""" Reset all environment variables of consequence """
47-
for variable_name in self.variable_names:
48-
os.environ.pop(variable_name, None)
49-
5035
def tearDown(self):
5136
# Stop Moto after each test
5237
self.mock.stop()
53-
self.unset_aws_credentials()
5438

5539

5640
def test_vanilla_create_queue(self):

0 commit comments

Comments
 (0)