Skip to content

Commit f5f1e2f

Browse files
author
Mikhail Zabaluev
committed
Don't use --all flag with cargo fmt
It adds nothing useful: cargo fmt checks all legitimate workspace members, and for the chain-deps we have a CI workflow in its own reposotiry. Moreover, the --all flag slows down the test run. Per suggestion in rust-lang/rustfmt#4247 (comment)
1 parent 42af676 commit f5f1e2f

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

.circleci/config.yml

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -96,18 +96,12 @@ jobs:
9696
- checkout
9797
- run: git submodule sync
9898
- run: git submodule update --init --depth=1
99-
- attach_workspace:
100-
at: .
101-
- restore_cache:
102-
name: Restore cargo registry index from cache
103-
keys:
104-
- cargo-index-v1-{{ checksum ".circleci/crates.io-index.head" }}
10599
- run:
106100
name: Print version information
107-
command: cargo fmt -- --version
101+
command: rustfmt --version
108102
- run:
109103
name: Check rustfmt
110-
command: cargo fmt --all -- --check
104+
command: cargo fmt -- --check
111105

112106
test_debug:
113107
executor: rust-stable
@@ -188,9 +182,7 @@ workflows:
188182
test_all:
189183
jobs:
190184
- cargo_fetch
191-
- rustfmt:
192-
requires:
193-
- cargo_fetch
185+
- rustfmt
194186
- cargo_audit:
195187
requires:
196188
- cargo_fetch

0 commit comments

Comments
 (0)