Skip to content

Commit f4cbcb8

Browse files
committed
Avoid duplicate version message
A version message is already emitted by initTxGenTracers. This is also a cleanup, as breaking the Action abstraction is ugly. Minor note: traceTxGeneratorVersion is no longer used.
1 parent 5f84d5f commit f4cbcb8

File tree

1 file changed

+2
-8
lines changed
  • bench/tx-generator/src/Cardano/Benchmarking

1 file changed

+2
-8
lines changed

bench/tx-generator/src/Cardano/Benchmarking/Script.hs

+2-8
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,12 @@ import Prelude
1212
import Control.Concurrent (threadDelay)
1313
import Control.Monad
1414
import Control.Monad.IO.Class
15-
import Control.Monad.Trans.Except
1615

1716
import Ouroboros.Network.NodeToClient (IOManager)
1817

1918
import Cardano.Benchmarking.Script.Action
2019
import Cardano.Benchmarking.Script.Aeson (parseScriptFileAeson)
21-
import Cardano.Benchmarking.Script.Core (setProtocolParameters, traceTxGeneratorVersion)
20+
import Cardano.Benchmarking.Script.Core (setProtocolParameters)
2221
import Cardano.Benchmarking.Script.Env
2322
import Cardano.Benchmarking.Script.Types
2423

@@ -38,12 +37,7 @@ runScript script iom = runActionM execScript iom >>= \case
3837
cleanup s a = void $ runActionMEnv s a iom
3938
execScript = do
4039
setProtocolParameters QueryLocalNode
41-
case break (\case StartProtocol {} -> True ; _ -> False) script of
42-
(beforeTracerInit, startProtoTracerInit : afterTracerInit) -> do
43-
sequence_ $ map action beforeTracerInit
44-
++ [action startProtoTracerInit, traceTxGeneratorVersion]
45-
++ map action afterTracerInit
46-
_ -> throwE $ UserError "runScript: StartProtocol missing"
40+
forM_ script action
4741

4842
shutDownLogging :: ActionM ()
4943
shutDownLogging = do

0 commit comments

Comments
 (0)