Skip to content

Commit 86abb82

Browse files
authored
chore(general): Bump CI to cat voices ci branch (#24)
* fix(general): Spelling * feat(general): Bump CI to proposed latest upstream version * fix(docs): Markdown format error in table * fix(docs): Spelling * fix(rust): Update standard configs to CI required versions. * ci(docs): Fix upstream CI earthfile reference * ci(general): Replace temp branch with tagged CI version.
1 parent 8193766 commit 86abb82

File tree

15 files changed

+87
-70
lines changed

15 files changed

+87
-70
lines changed

.config/dictionaries/project.dic

-9
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
aarch
22
abcz
33
ABNF
4-
abnf
54
addrr
65
adminer
76
anypolicy
@@ -23,12 +22,10 @@ BROTLI
2322
cantopen
2423
cardano
2524
CBOR
26-
cbor
2725
cbork
2826
cdylib
2927
CEST
3028
CHAINCODE
31-
chaincode
3229
chainsync
3330
childs
3431
Chotivichit
@@ -58,7 +55,6 @@ dotglob
5855
drep
5956
dreps
6057
Earthfile
61-
earthfile
6258
encryptor
6359
Errno
6460
Eternl
@@ -127,7 +123,6 @@ mdlint
127123
mdns
128124
memx
129125
Metadatum
130-
metadatum
131126
mimalloc
132127
minicbor
133128
miniprotocol
@@ -192,7 +187,6 @@ retriggering
192187
rlib
193188
rulelist
194189
RULENAME
195-
rulename
196190
runable
197191
rustc
198192
rustdoc
@@ -246,13 +240,11 @@ utimensat
246240
UTXO
247241
vitss
248242
Vkey
249-
vkey
250243
vkeywitness
251244
voteplan
252245
voteplans
253246
wallclock
254247
WASI
255-
wasi
256248
wasip
257249
wasmtime
258250
webasm
@@ -261,6 +253,5 @@ webpki
261253
WORKDIR
262254
xprivate
263255
XPRV
264-
xprv
265256
xpub
266257
yoroi

.markdownlint.jsonc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
// markdownlint JSON(C) configuration for Catalyst Standards
33
// Do not individually set markdown lint rules in documents.
4-
// It is permissable to disable a rule in a document if it is a false positive.
4+
// It is permissible to disable a rule in a document if it is a false positive.
55
// Keep the scope of the lint disable to as small as possible.
66
// See: https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md
77
// Default state for all rules

Earthfile

+4-8
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
VERSION 0.8
22

3-
IMPORT github.com/input-output-hk/catalyst-ci/earthly/mdlint:v3.2.00 AS mdlint-ci
4-
IMPORT github.com/input-output-hk/catalyst-ci/earthly/cspell:v3.2.00 AS cspell-ci
3+
IMPORT github.com/input-output-hk/catalyst-ci/earthly/mdlint:v3.2.03 AS mdlint-ci
4+
IMPORT github.com/input-output-hk/catalyst-ci/earthly/cspell:v3.2.03 AS cspell-ci
55

66
FROM debian:stable-slim
77

@@ -15,13 +15,9 @@ markdown-check-fix:
1515

1616
DO mdlint-ci+MDLINT_LOCALLY --src=$(echo ${PWD}) --fix=--fix
1717

18-
# Make sure the project dictionary is properly sorted.
18+
# clean-spelling-list : Make sure the project dictionary is properly sorted.
1919
clean-spelling-list:
20-
COPY .config/dictionaries/project.dic project.dic
21-
RUN sort -d -f project.dic > new.dic
22-
IF ! diff -q project.dic new.dic
23-
SAVE ARTIFACT new.dic AS LOCAL .config/dictionaries/project.dic
24-
END
20+
DO cspell-ci+CLEAN
2521

2622
# check-spelling : Check spelling in this repo inside a container.
2723
check-spelling:

docs/Earthfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
VERSION 0.8
22

3-
IMPORT github.com/input-output-hk/catalyst-ci/earthly/docs:v3.2.00 AS docs-ci
3+
IMPORT github.com/input-output-hk/catalyst-ci/earthly/docs:v3.2.03 AS docs-ci
44

55
IMPORT .. AS repo
66

integration_tests/rust/Earthfile

+16-15
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,26 @@
11
VERSION 0.8
22

3-
IMPORT github.com/input-output-hk/catalyst-ci/earthly/mithril_snapshot:v3.1.8 AS mithril-snapshot-ci
43
IMPORT ../../rust AS rust-workspace
54

6-
local-build:
7-
FROM rust-workspace+builder
5+
# TODO: This needs reworking, because we no longer have mithril snapshots inside CI.
86

9-
WORKDIR crates/cardano-chain-follower/testbed
10-
RUN cargo build -p overhead_benchmark --release
7+
#local-build:
8+
# FROM rust-workspace+builder
119

12-
SAVE ARTIFACT target/release/overhead_benchmark overhead_benchmark
10+
# WORKDIR crates/cardano-chain-follower/testbed
11+
# RUN cargo build -p overhead_benchmark --release
1312

14-
local-run-preprod:
15-
ARG --required BENCH_NAME
13+
# SAVE ARTIFACT target/release/overhead_benchmark overhead_benchmark
1614

17-
FROM +local-build
15+
#local-run-preprod:
16+
# ARG --required BENCH_NAME
1817

19-
COPY --dir mithril-snapshot-ci+package-preprod-snapshot/snapshot/immutable mithril_snapshot
20-
COPY +build/overhead_benchmark overhead_benchmark_bin
21-
RUN ./overhead_benchmark_bin --bench-name $BENCH_NAME --mithril-snapshot-path ./mithril_snapshot
18+
# FROM +local-build
2219

23-
local-save-preprod-snapshot:
24-
FROM mithril-snapshot-ci+package-preprod-snapshot
25-
SAVE ARTIFACT immutable AS LOCAL local_preprod_mithril_snapshot
20+
#COPY --dir mithril-snapshot-ci+package-preprod-snapshot/snapshot/immutable mithril_snapshot
21+
#COPY +build/overhead_benchmark overhead_benchmark_bin
22+
#RUN ./overhead_benchmark_bin --bench-name $BENCH_NAME --mithril-snapshot-path ./mithril_snapshot
23+
24+
#local-save-preprod-snapshot:
25+
#FROM mithril-snapshot-ci+package-preprod-snapshot
26+
#SAVE ARTIFACT immutable AS LOCAL local_preprod_mithril_snapshot

integration_tests/rust/overhead_benchmark/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ It doesn't matter which network the snapshot is from because the benchmark will
1111
There are 2 modes in which the benchmark can be executed:
1212

1313
| Benchmark name | Description |
14-
---------------------------|--------------|
14+
|--------------------------|--------------|
1515
| pallas | When executed with `--bench-name pallas`, the benchmark reads the Mithril snapshot from origin to its tip using only the `pallas` crate mechanisms |
1616
| cardano‑chain‑follower | When executed with `--bench-name cardano-chain-follower` it uses the `cardano-chain-follower` crate to follow the chain from origin to the tip of the specified snapshot |
1717

rust/Earthfile

+5-3
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
VERSION 0.8
22

3-
IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.2.01 AS rust-ci
3+
IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.2.03 AS rust-ci
44

5-
# Use when debugging cat-ci locally.
6-
# IMPORT ../../catalyst-ci/earthly/rust AS rust-ci
5+
# sync-cfg: Synchronize local config with CI version.
6+
# Must be run by the developer manually.
7+
sync-cfg:
8+
DO rust-ci+SYNC_STD_CFG
79

810
# builder : Set up our target toolchains, and copy our files.
911
builder:

rust/Justfile

+8-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ default:
1111
cargo-tree:
1212
cargo tree -e features,normal,build -f "{p}[{f}]" --workspace --frozen
1313

14+
# Synchronize STD Configs with the CI Version in use.
15+
sync-cfg:
16+
earthly +sync-cfg
17+
1418
# Check Dependency licenses and CVE's
1519
license-check:
1620
cargo deny check --exclude-dev
@@ -26,4 +30,7 @@ code-lint:
2630
cargo lint
2731

2832
# Pre Push Checks
29-
pre-push: code-format code-lint license-check
33+
pre-push: sync-cfg code-format code-lint license-check
34+
# Make sure we can actually build inside Earthly which needs to happen in CI.
35+
earthly +check
36+
earthly +build

rust/c509-certificate/Earthfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
VERSION 0.8
22

3-
IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.2.00 AS rust-ci
3+
IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust::v3.2.03 AS rust-ci
44

55
IMPORT .. AS rust-local
66
IMPORT ../.. AS repo

rust/cardano-chain-follower/src/mithril_snapshot_sync.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -164,13 +164,13 @@ async fn get_snapshot(
164164
if let Some(snapshot) = snapshot {
165165
snapshot
166166
} else {
167-
// Some kind of communications error has ocurred.
167+
// Some kind of communications error has occurred.
168168
error!("No snapshot returned for {} ???", network);
169169
return None;
170170
}
171171
},
172172
Err(err) => {
173-
// Some kind of communications error has ocurred.
173+
// Some kind of communications error has occurred.
174174
error!(
175175
"Failure to get the latest snapshot for {} with error: {}",
176176
network, err

rust/cbork-abnf-parser/tests/testsuite/alternations.rs

+4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
//! Test Alternations through the parser.
2+
3+
// cspell: words nbaz
4+
15
use cbork_abnf_parser::{self, abnf_test::Rule};
26

37
use crate::common::*;

rust/cbork/Earthfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
VERSION 0.8
22

3-
IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust:v3.2.00 AS rust-ci
3+
IMPORT github.com/input-output-hk/catalyst-ci/earthly/rust::v3.2.03 AS rust-ci
44

55
IMPORT .. AS rust-local
66

rust/deny.toml

+6-3
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,13 @@ ignore = [
2626
multiple-versions = "warn"
2727
wildcards = 'deny'
2828
deny = [
29-
# { crate = "git2", use-instead = "gix" },
30-
{ crate = "openssl", use-instead = "rustls" },
31-
{ crate = "openssl-sys", use-instead = "rustls" },
29+
# Scylla DB Drivers currently require OpenSSL. Its unavoidable.
30+
# However, there is movement to enable support for Rustls.
31+
# So, for now, allow open-ssl but it needs to be disabled as soon as Scylla DB enables Rustls.
32+
#{ crate = "openssl", use-instead = "rustls" },
33+
#{ crate = "openssl-sys", use-instead = "rustls" },
3234
"libssh2-sys",
35+
# { crate = "git2", use-instead = "gix" },
3336
# { crate = "cmake", use-instead = "cc" },
3437
# { crate = "windows", reason = "bloated and unnecessary", use-instead = "ideally inline bindings, practically, windows-sys" },
3538
]

rust/rust-toolchain.toml

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
[toolchain]
22
channel = "1.80"
3-
profile = "default"
4-
targets = ["x86_64-unknown-linux-musl"]
3+
profile = "default"

rust/rustfmt.toml

+36-22
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
# Compatibility:
2-
edition = "2021"
3-
41
# Enable unstable features:
52
# * imports_indent
63
# * imports_layout
@@ -23,32 +20,49 @@ edition = "2021"
2320
# * overflow_delimited_expr
2421
unstable_features = true
2522

26-
blank_lines_upper_bound = 1
27-
comment_width = 90
28-
condense_wildcard_suffixes = true
29-
fn_params_layout = "Compressed"
30-
force_multiline_blocks = true
31-
format_code_in_doc_comments = true
32-
format_generated_files = false
33-
group_imports = "StdExternalCrate"
23+
# Compatibility:
24+
edition = "2021"
25+
26+
# Tabs & spaces - Defaults, listed for clarity
27+
tab_spaces = 4
3428
hard_tabs = false
35-
hex_literal_case = "Upper"
36-
imports_granularity = "Crate"
37-
imports_indent = "Block"
38-
imports_layout = "Mixed"
39-
inline_attribute_width = 0
29+
30+
# Commas.
31+
trailing_comma = "Vertical"
4032
match_block_trailing_comma = true
33+
34+
# General width constraints.
4135
max_width = 100
36+
37+
# Comments:
4238
normalize_comments = true
4339
normalize_doc_attributes = true
44-
overflow_delimited_expr = true
45-
reorder_impl_items = true
40+
wrap_comments = true
41+
comment_width = 90 # small excess is okay but prefer 80
42+
format_code_in_doc_comments = true
43+
format_generated_files = false
44+
45+
# Imports.
46+
imports_indent = "Block"
47+
imports_layout = "Mixed"
48+
group_imports = "StdExternalCrate"
4649
reorder_imports = true
47-
tab_spaces = 4
48-
trailing_comma = "Vertical"
49-
use_field_init_shorthand = true
50+
imports_granularity = "Crate"
51+
52+
# Arguments:
5053
use_small_heuristics = "Default"
54+
fn_params_layout = "Compressed"
55+
overflow_delimited_expr = true
5156
where_single_line = true
52-
wrap_comments = true
5357

58+
# Misc:
59+
inline_attribute_width = 0
60+
blank_lines_upper_bound = 1
61+
reorder_impl_items = true
62+
use_field_init_shorthand = true
63+
force_multiline_blocks = true
64+
condense_wildcard_suffixes = true
65+
hex_literal_case = "Upper"
66+
67+
# Ignored files:
5468
ignore = []

0 commit comments

Comments
 (0)