fixup! feat!: add deposit to stake pool registration certificates

Author: iccicci

packages/cardano-services/test/ChainHistory/DbSyncChainHistoryProvider/mappers.test.ts

@@ -204,12 +204,14 @@ describe('chain history mappers', () => {
     test('map PoolUpdateCertModel to Cardano.PoolRegistrationCertificate', () => {
       const result = mappers.mapCertificate({
         ...baseCertModel,
+        deposit: '500000000',
         pool_id: poolId,
         type: 'register'
       } as WithCertType<PoolRegisterCertModel>);
       expect(result).toEqual<WithCertIndex<Cardano.PoolRegistrationCertificate>>({
         __typename: Cardano.CertificateType.PoolRegistration,
         cert_index: 0,
+        deposit: 500_000_000n,
         poolParameters: null as unknown as Cardano.PoolParameters
       });
     });

packages/core/src/Cardano/types/Certificate.ts

@@ -115,7 +115,7 @@ export interface StakeAddressCertificate {
 
 export interface PoolRegistrationCertificate {
   __typename: CertificateType.PoolRegistration;
-  deposit: Lovelace;
+  deposit?: Lovelace;
   poolParameters: PoolParameters;
 }
 

packages/core/src/Serialization/Certificates/PoolRegistration.ts

@@ -13,7 +13,6 @@ const EMBEDDED_GROUP_SIZE = 10;
  * about the pool such as the pledge, costs, margin, reward account, and the pool's owners and relays.
  */
 export class PoolRegistration {
-  #deposit: Cardano.Lovelace;
   #params: PoolParams;
   #originalBytes: HexBlob | undefined = undefined;
 
@@ -22,8 +21,7 @@ export class PoolRegistration {
    *
    * @param params The pool registration/update parameters.
    */
-  constructor(params: PoolParams, deposit: Cardano.Lovelace) {
-    this.#deposit = deposit;
+  constructor(params: PoolParams) {
     this.#params = params;
   }
 
@@ -148,8 +146,7 @@ export class PoolRegistration {
 
     reader.readEndArray();
 
-    // TODO: the hard-coded 0 deposit should actually be read/computed from tx implicit coins (?)
-    const cert = new PoolRegistration(params, 0n);
+    const cert = new PoolRegistration(params);
     cert.#originalBytes = cbor;
 
     return cert;
@@ -163,7 +160,6 @@ export class PoolRegistration {
   toCore(): Cardano.PoolRegistrationCertificate {
     return {
       __typename: Cardano.CertificateType.PoolRegistration,
-      deposit: this.#deposit,
       poolParameters: this.#params.toCore()
     };
   }
@@ -174,7 +170,7 @@ export class PoolRegistration {
    * @param cert core PoolRegistrationCertificate object.
    */
   static fromCore(cert: Cardano.PoolRegistrationCertificate) {
-    return new PoolRegistration(PoolParams.fromCore(cert.poolParameters), cert.deposit); // TODO: Core type does not support script hash as credential, fix?
+    return new PoolRegistration(PoolParams.fromCore(cert.poolParameters)); // TODO: Core type does not support script hash as credential, fix?
   }
 
   /**

packages/projection/src/operators/Mappers/certificates/withStakePools.ts

@@ -31,8 +31,6 @@ export const withStakePools = unifiedProjectorOperator<WithCertificates & WithEp
     switch (certificate.__typename) {
       case Cardano.CertificateType.PoolRegistration:
         updates[certificate.poolParameters.id] = {
-          // TODO: the hard-coded 0 deposit should actually be read/computed from tx implicit coins or from stake pool status (?)
-          deposit: 0n,
           poolParameters: certificate.poolParameters,
           source
         };