fix: plutus list now serializes using the correct encoding depending on its size

Author: AngelCastilloB

packages/core/src/Serialization/PlutusData/PlutusList.ts

@@ -6,7 +6,6 @@ import { bytesToHex, hexToBytes } from '../../util/misc';
 /** A list of plutus data. */
 export class PlutusList {
   readonly #array = new Array<PlutusData>();
-  #useIndefiniteEncoding = false;
 
   /**
    * Serializes this PlutusList instance into its CBOR representation as a Uint8Array.
@@ -15,8 +14,9 @@ export class PlutusList {
    */
   toCbor(): HexBlob {
     const writer = new CborWriter();
+    const shouldUseIndefinite = this.#array.length > 0;
 
-    if (this.#useIndefiniteEncoding) {
+    if (shouldUseIndefinite) {
       writer.writeStartArray();
     } else {
       writer.writeStartArray(this.#array.length);
@@ -26,7 +26,7 @@ export class PlutusList {
       writer.writeEncodedValue(hexToBytes(elem.toCbor()));
     }
 
-    if (this.#useIndefiniteEncoding) writer.writeEndArray();
+    if (shouldUseIndefinite) writer.writeEndArray();
 
     return HexBlob.fromBytes(writer.encode());
   }
@@ -41,9 +41,7 @@ export class PlutusList {
     const list = new PlutusList();
     const reader = new CborReader(cbor);
 
-    const length = reader.readStartArray();
-
-    if (length === null) list.#useIndefiniteEncoding = true;
+    reader.readStartArray();
 
     while (reader.peekState() !== CborReaderState.EndArray) {
       list.add(PlutusData.fromCbor(bytesToHex(reader.readEncodedValue())));
@@ -88,7 +86,6 @@ export class PlutusList {
    * @returns true if objects are equals; otherwise false.
    */
   equals(other: PlutusList): boolean {
-    if (this.#useIndefiniteEncoding !== other.#useIndefiniteEncoding) return false;
     if (this.#array.length !== other.#array.length) return false;
 
     for (let i = 0; i < this.#array.length; ++i) {

packages/core/test/Serialization/PlutusData.test.ts

@@ -133,6 +133,12 @@ describe('PlutusData', () => {
   });
 
   describe('List', () => {
+    it('can encode an empty plutus list', () => {
+      const data = new Serialization.PlutusList();
+
+      expect(data.toCbor()).toEqual('80');
+    });
+
     it('can encode simple plutus list', () => {
       const data = new Serialization.PlutusList();
 
@@ -142,7 +148,7 @@ describe('PlutusData', () => {
       data.add(Serialization.PlutusData.newInteger(4n));
       data.add(Serialization.PlutusData.newInteger(5n));
 
-      expect(data.toCbor()).toEqual('850102030405');
+      expect(data.toCbor()).toEqual('9f0102030405ff');
     });
 
     it('can encode a list of plutus list', () => {
@@ -162,7 +168,7 @@ describe('PlutusData', () => {
       outer.add(Serialization.PlutusData.newList(innerList));
       outer.add(Serialization.PlutusData.newInteger(5n));
 
-      expect(outer.toCbor()).toEqual('85010285010203040585010203040505');
+      expect(outer.toCbor()).toEqual('9f01029f0102030405ff9f0102030405ff05ff');
     });
   });
 
@@ -292,7 +298,7 @@ describe('PlutusData', () => {
 
       const data = new Serialization.ConstrPlutusData(0n, args);
 
-      expect(data.toCbor()).toEqual('d879850102030405');
+      expect(data.toCbor()).toEqual('d8799f0102030405ff');
     });
   });
 

packages/ogmios/test/CardanoNode/__snapshots__/ObservableOgmiosCardanoNode.test.ts.snap

@@ -91,19 +91,19 @@ Array [
               },
               Object {
                 "data": Object {
-                  "cbor": "9fd866821901739fd866821902dd9f2341e14478c0fcf5ff22d866821903e39f438002ab0104ffa1448858788900ff029fa040ffff",
+                  "cbor": "83d866821901739fd866821902dd9f2341e14478c0fcf5ff22d866821903e39f438002ab0104ffa1448858788900ff029fa040ff",
                   "items": Array [
                     Object {
                       "cbor": "d866821901739fd866821902dd9f2341e14478c0fcf5ff22d866821903e39f438002ab0104ffa1448858788900ff",
                       "constructor": 371n,
                       "fields": Object {
-                        "cbor": "9fd866821902dd9f2341e14478c0fcf5ff22d866821903e39f438002ab0104ffa1448858788900ff",
+                        "cbor": "84d866821902dd9f2341e14478c0fcf5ff22d866821903e39f438002ab0104ffa1448858788900",
                         "items": Array [
                           Object {
                             "cbor": "d866821902dd9f2341e14478c0fcf5ff",
                             "constructor": 733n,
                             "fields": Object {
-                              "cbor": "9f2341e14478c0fcf5ff",
+                              "cbor": "832341e14478c0fcf5",
                               "items": Array [
                                 -4n,
                                 Uint8Array [
@@ -123,7 +123,7 @@ Array [
                             "cbor": "d866821903e39f438002ab0104ff",
                             "constructor": 995n,
                             "fields": Object {
-                              "cbor": "9f438002ab0104ff",
+                              "cbor": "83438002ab0104",
                               "items": Array [
                                 Uint8Array [
                                   128,
@@ -151,7 +151,7 @@ Array [
                     },
                     2n,
                     Object {
-                      "cbor": "9fa040ff",
+                      "cbor": "82a040",
                       "items": Array [
                         Object {
                           "cbor": "a0",

packages/ogmios/test/ogmiosToCore/__snapshots__/block.test.ts.snap

@@ -142,7 +142,7 @@ Object {
                   96,
                 ] => 2n,
                 Object {
-                  "cbor": "9f20a3419c204386a48244e21bd936202004a0ff",
+                  "cbor": "8420a3419c204386a48244e21bd936202004a0",
                   "items": Array [
                     -1n,
                     Object {
@@ -189,7 +189,7 @@ Object {
                         -4n => Uint8Array [],
                       },
                     } => Object {
-                      "cbor": "9f414d429b3f0440ff",
+                      "cbor": "84414d429b3f0440",
                       "items": Array [
                         Uint8Array [
                           77,
@@ -206,7 +206,7 @@ Object {
                       "cbor": "a0",
                       "data": Map {},
                     } => Object {
-                      "cbor": "9f034001ff",
+                      "cbor": "83034001",
                       "items": Array [
                         3n,
                         Uint8Array [],
@@ -225,7 +225,7 @@ Object {
                       "cbor": "d8668218da9f2341440302413eff",
                       "constructor": 218n,
                       "fields": Object {
-                        "cbor": "9f2341440302413eff",
+                        "cbor": "852341440302413e",
                         "items": Array [
                           -4n,
                           Uint8Array [
@@ -251,7 +251,7 @@ Object {
                       "cbor": "d866821901939f23ff",
                       "constructor": 403n,
                       "fields": Object {
-                        "cbor": "9f23ff",
+                        "cbor": "8123",
                         "items": Array [
                           -4n,
                         ],