chore: disable promise/always-return eslint rule

Author: iccicci

.eslintrc.js

@@ -61,6 +61,7 @@ module.exports = {
     'no-unused-expressions': 'off',
     'no-unused-vars': 0,
     'no-useless-constructor': 0,
+    'promise/always-return': 0,
     'promise/avoid-new': 0,
     quotes: ['error', 'single', { avoidEscape: true }],
     'sort-imports': ['warn', { ignoreDeclarationSort: true }],

packages/e2e/test/long-running/multisig-wallet/MultiSigWallet.ts

@@ -256,7 +256,6 @@ export class MultiSigWallet {
           new Observable<Cardano.Utxo[]>((subscriber) => {
             this.#utxoProvider
               .utxoByAddresses({ addresses: [this.#address.address] })
-              // eslint-disable-next-line promise/always-return
               .then((utxos) => {
                 subscriber.next(utxos);
               })
@@ -293,7 +292,6 @@ export class MultiSigWallet {
                   startAt: 0
                 }
               })
-              // eslint-disable-next-line promise/always-return
               .then((paginatedTxs) => {
                 subscriber.next(paginatedTxs.pageResults);
                 subscriber.complete();
@@ -318,7 +316,6 @@ export class MultiSigWallet {
               .rewardsHistory({
                 rewardAccounts: [this.#address.rewardAccount]
               })
-              // eslint-disable-next-line promise/always-return
               .then((rewardsHistory) => {
                 subscriber.next(rewardsHistory);
                 subscriber.complete();
@@ -343,7 +340,6 @@ export class MultiSigWallet {
               .rewardAccountBalance({
                 rewardAccount: this.#address.rewardAccount
               })
-              // eslint-disable-next-line promise/always-return
               .then((rewardAccountBalance) => {
                 subscriber.next(rewardAccountBalance);
                 subscriber.complete();

packages/e2e/test/projection/single-tenant-utxo.test.ts

@@ -1,4 +1,3 @@
-/* eslint-disable promise/always-return */
 import * as Postgres from '@cardano-sdk/projection-typeorm';
 import { Bootstrap, Mappers, ProjectionEvent, requestNext } from '@cardano-sdk/projection';
 import { Cardano, ObservableCardanoNode } from '@cardano-sdk/core';

packages/e2e/test/wallet_epoch_0/PersonalWallet/plutusTest.test.ts

@@ -175,7 +175,6 @@ const getScriptUtxoSet = (
         new Observable<Cardano.Utxo[]>((subscriber) => {
           utxoProvider
             .utxoByAddresses({ addresses: [scriptAddress] })
-            // eslint-disable-next-line promise/always-return
             .then((utxos) => {
               subscriber.next(utxos);
             })

packages/ogmios/src/CardanoNode/OgmiosObservableCardanoNode/OgmiosObservableCardanoNode.ts

@@ -179,10 +179,8 @@ export class OgmiosObservableCardanoNode implements ObservableCardanoNode {
       switchMap(
         (interactionContext) =>
           new Observable<ObservableChainSync>((subscriber) => {
-            // eslint-disable-next-line promise/always-return
             if (subscriber.closed) return;
             void ChainSynchronization.findIntersection(interactionContext, points.map(pointOrOriginToOgmios))
-              // eslint-disable-next-line promise/always-return
               .then((ogmiosIntersection) => {
                 const intersection = ogmiosToCoreIntersection(ogmiosIntersection);
                 subscriber.next({

packages/wallet/src/persistence/pouchDbStores/PouchDbCollectionStore.ts

@@ -1,4 +1,3 @@
-/* eslint-disable promise/always-return */
 import { CollectionStore } from '../types';
 import { EMPTY, Observable, Subject, from } from 'rxjs';
 import { Logger } from 'ts-log';

packages/wallet/src/persistence/pouchDbStores/PouchDbDocumentStore.ts

@@ -1,4 +1,3 @@
-/* eslint-disable promise/always-return */
 import { DocumentStore } from '../types';
 import { EMPTY, Observable } from 'rxjs';
 import { Logger } from 'ts-log';

packages/wallet/src/persistence/pouchDbStores/PouchDbKeyValueStore.ts

@@ -1,5 +1,4 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
-/* eslint-disable promise/always-return */
 import { EMPTY, Observable, from } from 'rxjs';
 import { KeyValueCollection, KeyValueStore } from '../types';
 import { Logger } from 'ts-log';

packages/wallet/src/persistence/pouchDbStores/PouchDbStore.ts

@@ -80,7 +80,6 @@ export abstract class PouchDbStore<T extends {}> {
             _rev: await this.#getRev(docId),
             ...serializableDoc
           };
-          // eslint-disable-next-line promise/always-return
           try {
             await this.db.put(pouchDbDoc, { force: true });
           } catch (error) {

packages/wallet/test/PersonalWallet/methods.test.ts

@@ -1,4 +1,4 @@
-/* eslint-disable unicorn/consistent-destructuring, sonarjs/no-duplicate-string, @typescript-eslint/no-floating-promises, promise/no-nesting, promise/always-return */
+/* eslint-disable unicorn/consistent-destructuring, sonarjs/no-duplicate-string, @typescript-eslint/no-floating-promises, promise/no-nesting */
 import * as Crypto from '@cardano-sdk/crypto';
 import { AddressDiscovery, BaseWallet, TxInFlight, createPersonalWallet } from '../../src';
 import { AddressType, Bip32Account, GroupedAddress, Witnesser, util } from '@cardano-sdk/key-management';

packages/web-extension/test/remoteApi/remoteApi.integration.test.ts

@@ -555,7 +555,6 @@ describe('remoteApi integration', () => {
             return !consumerMessage$.observed && !hostMessage$.observed;
           };
           // Create and consume a new remote api through another API's factory method
-          // eslint-disable-next-line promise/always-return
           void Promise.resolve(getFactory(sut.consumer)()).then(() => {
             expect(destructor.callbacks).toHaveLength(1);
             setTimeout(() => {