fix(core): do not allow comma as invalid handle

also add whitespace cases in for handle tests and add doc comment

Author: mkazlauskas

packages/core/src/Asset/util/isValidHandle.ts

@@ -1,4 +1,12 @@
+/**
+ * From ADA Handle FAQ:
+ * Alphanumeric: [a-z][A-Z][0-9]
+ * Dash: -
+ * Underscore: _
+ * Period: .
+ * Pipe: | (in general it is not valid, but an exception exists in mainnet)
+ */
 export const isValidHandle = (handle: string) => {
-  const pattern = /^[\w,.|\-]*@{0,1}[\w,.|\-]+$/;
+  const pattern = /^[\w.|\-]*@{0,1}[\w.|\-]+$/;
   return pattern.test(handle);
 };

packages/core/test/Asset/util/isValidHandle.test.ts

@@ -4,6 +4,7 @@ const validHandles = [
   'bob',
   'a',
   'alice',
+  '_',
   'test-handle',
   'test.handle',
   'test-handle-123',
@@ -12,6 +13,7 @@ const validHandles = [
   'handle_name',
   '@alice',
   'test-@handle',
+  '_@_',
   '0|0',
   '0|0@0|0'
 ];
@@ -25,6 +27,12 @@ const invalidHandles = [
   'ada%1_test',
   'lace ',
   'wallet ',
+  'comma,',
+  'comma,@sub',
+  'sub@comma,',
+  '\n',
+  '\r',
+  ' ',
   'sub@sub@handle'
 ];