ci: fix the condition for images

Author: michalrus

.github/workflows/std.yml

@@ -1,13 +1,6 @@
 # yq -y < std-unexploded.yml > workflows/std.yml
 name: STD
 on:
-  workflow_dispatch:
-    inputs:
-      deploy:
-        description: Deploy to dev-preview
-        type: boolean
-        required: true
-        default: false
   workflow_call:
   pull_request:
     branches:
@@ -71,32 +64,35 @@ jobs:
           ${{ steps.discovery.outputs.hits }}
           VERY_UNLIKELY_DELIMITER
           echo ==============================================
-          exit 77
 
 
   images:
     name: ${{ matrix.target.jobName }}
     runs-on: ubuntu-latest
     needs: discover
-    if: fromJSON(needs.discover.outputs.hits).oci-images.publish != '{}'
     strategy:
       matrix:
-        target: ${{ fromJSON(needs.discover.outputs.hits).oci-images.publish }}
+        target: ${{ contains(fromJSON(needs.discover.outputs.hits), 'oci-images') && fromJSON(needs.discover.outputs.hits).oci-images.publish || fromJSON('["dummy-target"]') }}
     steps:
       - name: Configure AWS Credentials
+        if: matrix.target != 'dummy-target'
         uses: aws-actions/[email protected]
         with:
           role-to-assume: ${{ env.AWS_ROLE_ARN }}
           aws-region: ${{ env.AWS_REGION }}
       - name: Login to Amazon ECR
+        if: matrix.target != 'dummy-target'
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
       - uses: nixbuild/nix-quick-install-action@v25
+        if: matrix.target != 'dummy-target'
       - uses: nixbuild/nixbuild-action@v17
+        if: matrix.target != 'dummy-target'
         with:
           nixbuild_ssh_key: ${{ secrets.SSH_PRIVATE_KEY }}
           generate_summary_for: job
       - uses: divnix/std-action/setup-discovery-ssh@main
+        if: matrix.target != 'dummy-target'
         with:
           ssh_key: ${{ secrets.SSH_PRIVATE_KEY }}
           user_name: ${{ env.DISCOVERY_USER_NAME }}
@@ -106,16 +102,18 @@ jobs:
         run: |
           echo commit: ${{ github.sha }}
       - uses: divnix/std-action/run@main
+        if: matrix.target != 'dummy-target'
         with: {ffBuildInstructions: true, remoteStore: "ssh-ng://eu.nixbuild.net"}
 
   ### FIXME:
-  ### FIXME: change all instances of `dev-preview` in `diff-to-us` back to `${{ github.ref_name }}`
+  ### FIXME: change all instances of `dev-preview` in `diff-to-us` back to a proper expression;
+  ### FIXME: remove all mentions of `chore/LW-9879-lace-ops-to-sdk`
   ### FIXME:
 
   diff-to-us:
     needs: images
     name: Comment with a Plan Diff (${{ github.ref_name }})
-    if: github.event_name == 'pull_request' && (github.ref_name == 'dev-preview' || github.ref_name == 'chore/LW-9879-lace-ops-to-sdk')
+    if: github.event_name == 'pull_request' && (github.base_ref == 'dev-preview' || github.head_ref == 'chore/LW-9879-lace-ops-to-sdk')
     runs-on: ubuntu-22.04
     steps:
       - uses: actions/checkout@v4
@@ -152,9 +150,8 @@ jobs:
 
 
   deploy-to-us:
-    if: github.ref_name == 'dev-preview'
-    # TODO: if: github.ref_name == 'dev-preview' || github.ref_name == 'chore/LW-9879-lace-ops-to-sdk'
-    needs: [images, diff-to-us]
+    if: github.event_name == 'push' && github.ref_name == 'dev-preview'
+    needs: [images]
     concurrency:
       # Only one deployment at a time per environment, and wait for the previous one to finish:
       group: deploy-${{ github.ref_name }}