chore: misc improvements

Author: Evalir

src/tasks/block/sim.rs

@@ -221,7 +221,7 @@ impl Simulator {
         // We have the timepoint in seconds into the slot. To find out what's
         // remaining, we need to subtract it from the slot duration
         // we also subtract 3 seconds to account for the sequencer stopping signing.
-        let remaining = (self.slot_calculator().slot_duration() - timepoint).saturating_sub(3);
+        let remaining = (self.slot_calculator().slot_duration() - timepoint).saturating_sub(4);
 
         let deadline = Instant::now() + Duration::from_secs(remaining);
         deadline.max(Instant::now())

src/tasks/cache/bundle.rs

@@ -12,6 +12,9 @@ use tokio::{
     time::{self, Duration},
 };
 
+/// Poll interval for the bundle poller in milliseconds.
+const POLL_INTERVAL_MS: u64 = 500;
+
 /// The BundlePoller polls the tx-pool for bundles.
 #[derive(Debug)]
 pub struct BundlePoller {
@@ -29,7 +32,12 @@ pub struct BundlePoller {
 impl BundlePoller {
     /// Creates a new BundlePoller from the provided builder config.
     pub fn new(config: &BuilderConfig, token: SharedToken) -> Self {
-        Self { config: config.clone(), token, client: Client::new(), poll_interval_ms: 1000 }
+        Self {
+            config: config.clone(),
+            token,
+            client: Client::new(),
+            poll_interval_ms: POLL_INTERVAL_MS,
+        }
     }
 
     /// Creates a new BundlePoller from the provided builder config and with the specified poll interval in ms.

src/tasks/cache/tx.rs

@@ -8,6 +8,9 @@ use serde::{Deserialize, Serialize};
 use std::time::Duration;
 use tokio::{sync::mpsc, task::JoinHandle, time};
 
+/// Poll interval for the transaction poller in milliseconds.
+const POLL_INTERVAL_MS: u64 = 500;
+
 /// Models a response from the transaction pool.
 #[derive(Debug, Clone, Serialize, Deserialize)]
 struct TxPoolResponse {
@@ -32,7 +35,7 @@ impl TxPoller {
     /// Returns a new [`TxPoller`] with the given config.
     /// * Defaults to 1000ms poll interval (1s).
     pub fn new(config: &BuilderConfig) -> Self {
-        Self { config: config.clone(), client: Client::new(), poll_interval_ms: 1000 }
+        Self { config: config.clone(), client: Client::new(), poll_interval_ms: POLL_INTERVAL_MS }
     }
 
     /// Returns a new [`TxPoller`] with the given config and cache polling interval in milliseconds.

src/tasks/env.rs

@@ -90,7 +90,7 @@ impl EnvTask {
                 Some(value) => value,
                 None => {
                     // If we failed to get the rollup header, we skip this iteration.
-                    debug!(%block_hash, "failed to get rollup header - continuint to next block");
+                    debug!(%block_hash, "failed to get rollup header - continuing to next block");
                     continue;
                 }
             };

src/tasks/metrics.rs

@@ -53,11 +53,11 @@ impl MetricsTask {
 
                     // log whether the transaction reverted
                     if receipt.status() {
-                        counter!("metrics.tx_reverted").increment(1);
-                        debug!("tx reverted");
-                    } else {
                         counter!("metrics.tx_succeeded").increment(1);
                         debug!("tx succeeded");
+                    } else {
+                        counter!("metrics.tx_reverted").increment(1);
+                        debug!("tx reverted");
                     }
                 }
                 Err(PendingTransactionError::TxWatcher(WatchTxError::Timeout)) => {