Add to irrelevant_files list #217
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,7 +58,26 @@ | |
| roles: | ||
| - zuul: github.com/openstack-k8s-operators/ci-framework | ||
| required-projects: *required_projects | ||
| irrelevant-files: | ||
| # *irrelevant_files | ||
| - .github/.* | ||
| - ci/github/.* | ||
| - callback_plugins/.* | ||
| - README* | ||
| - .*/*.md | ||
| - roles/client_side_tests/.* | ||
| - roles/test_alerts/.* | ||
| - roles/test_collectd/.* | ||
| - roles/test_metrics_retention/.* | ||
| - roles/test_observability_strategy/.* | ||
| - roles/test_qdr/.* | ||
| - roles/test_sensubility/.* | ||
| - roles/test_snmp_traps/.* | ||
| - roles/test_verify_email/.* | ||
| # | ||
| - roles/telemetry_graphing | ||
| - roles/telemetry_autoscaling | ||
| - roles/telemetry_verify_metrics | ||
|
|
||
| - job: | ||
| name: functional-metric-verification-tests-osp18 | ||
|
|
@@ -75,7 +94,25 @@ | |
| roles: | ||
| - zuul: github.com/openstack-k8s-operators/ci-framework | ||
| required-projects: *required_projects | ||
| irrelevant-files: | ||
|
There was a problem hiding this comment. Maybe "files" is better than irrelevant-files, since it will result in a shorter list. i.e. something like source: https://zuul-ci.org/docs/zuul/latest/config/job.html#attr-job.files There was a problem hiding this comment. I just learned that there's that negate option for file name matching |
||
| # *irrelevant_files | ||
| - .github/.* | ||
| - ci/github/.* | ||
| - callback_plugins/.* | ||
| - README* | ||
| - .*/*.md | ||
| - roles/client_side_tests/.* | ||
| - roles/test_alerts/.* | ||
| - roles/test_collectd/.* | ||
| - roles/test_metrics_retention/.* | ||
| - roles/test_observability_strategy/.* | ||
| - roles/test_qdr/.* | ||
| - roles/test_sensubility/.* | ||
| - roles/test_snmp_traps/.* | ||
| - roles/test_verify_email/.* | ||
| # | ||
| - roles/telemetry_graphing | ||
| - roles/telemetry_logging | ||
|
|
||
| - job: | ||
| name: feature-verification-tests-noop | ||
|
|
@@ -101,8 +138,25 @@ | |
| roles: | ||
| - zuul: github.com/openstack-k8s-operators/ci-framework | ||
| required-projects: *required_projects | ||
| irrelevant-files: | ||
| # *irrelevant_files | ||
| - .github/.* | ||
| - ci/github/.* | ||
| - callback_plugins/.* | ||
| - README* | ||
| - .*/*.md | ||
| - roles/client_side_tests/.* | ||
| - roles/test_alerts/.* | ||
| - roles/test_collectd/.* | ||
| - roles/test_metrics_retention/.* | ||
| - roles/test_observability_strategy/.* | ||
| - roles/test_qdr/.* | ||
| - roles/test_sensubility/.* | ||
| - roles/test_snmp_traps/.* | ||
| - roles/test_verify_email/.* | ||
| # | ||
| - roles/telemetry_logging | ||
| - roles/telemetry_verify_metrics | ||
|
|
||
| - project: | ||
| name: infrawatch/feature-verification-tests | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks less than ideal. Can a combination of file and irrelevant-files be used?
Or perhaps a yaml anchor?
I looked at this article: https://medium.com/@kinghuang/docker-compose-anchors-aliases-extensions-a1e4105d70bd, I think something like this should work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried the following with failure:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per rhos-prodchain-support:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boo! (not directed at anyone)
This is annoying, but since it works and the alternatives were unsuccessful, then it'll have to do.
Thank you for looking at this and testing the alternatives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the irrelevant-files should support matching on regular expressions. It could make the list look tidier, and prevent issues later when new roles get added
Please try that out if it's not a huge effort (perhaps as a follow-up PR once this is done)