Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common] Update the CR tests to mark one as optional #207

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[common] Update the CR tests to mark one as optional #207

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c848ae
[common] Update the CR tests to mark one as optional
elfiesmelfie Nov 27, 2024
60bd683
Add conditions to task
elfiesmelfie Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions roles/common/tasks/cr_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,24 @@
failed_when:
- result.rc != 0

- name: Verify that a CR is ready {{ common_cr_ready_test_id }}
# This is added so that the task name will be rendered correctly
# If item.condition_type is used and it doesn't exist, then the
# literal template text will appear as the task name
# e.g. "Verify that the {{ item.kind }} {{ item.name }} CR is {{ item.condition_type }}"
- name: Set the condition type
ansible.builtin.set_fact:
condition_type: "{{ item.condition_type if item.condition_type is defined else '' }}"

- name: |
{{ 'TEST' if condition_type | length > 0 }} Verify that the {{ item.kind }} {{ item.name }} CR is {{ condition_type }}
{{ common_cr_ready_test_id if condition_type | length > 0 }}
ansible.builtin.command:
cmd: |
oc get {{ item.kind }} {{ item.name }} -o jsonpath='{.status.conditions[?(@.type=="{{ item.condition_type }}")].status}{"\n"}'
oc get {{ item.kind }} {{ item.name }} -o jsonpath='{.status.conditions[?(@.type=="{{ condition_type }}")].status}{"\n"}'
register: result
changed_when: false
failed_when:
- result.stdout != "True"
when:
- common_cr_ready_test_id is defined
- item.condition_type is defined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are CRs, which don't have status conditions to check, so in that case the cr_test would just check their existence (the top task of this file). What happens with the when removed? I think it just fails in that case right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an answer for that. Looking at this here, I think the when should be re-added. I can't remember why it was removed.

- condition_type | length > 0
Loading