You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Integrate the implemented ICS-23 verification logic into the CometClientComponent and implement the verify_(non_)membership methods there.
This also includes adding integration tests in Cairo, and updating the relayer to incorporate the necessary commitment proofs from the Cosmos side when constructing packets. Without these proofs, the IBC handlers will reject the dummy packets. If the changes required in the relayer turn out to be extensive, they can be addressed as a separate issue. This will depend on whether the necessary components are available in both the hermes-sdk and Starknet’s relayer.
(cc @soareschen for more insight into what might need to be done for the relayer.)
The text was updated successfully, but these errors were encountered:
The main thing to consider is that the proofs should be in byte array. The other challenge is that the MerkleProof struct is originally encoded as protobuf. So we need to either implement protobuf decoding for MerkleProof in Cairo, or implement Cairo decoding for MerkleProof on the relayer. Compared to PacketData, this is simpler as the relayer do not need to treat the proofs as opaque data.
Comes after #208, as part of #164
Context
Integrate the implemented ICS-23 verification logic into the
CometClientComponent
and implement theverify_(non_)membership
methods there.This also includes adding integration tests in Cairo, and updating the relayer to incorporate the necessary commitment proofs from the Cosmos side when constructing packets. Without these proofs, the IBC handlers will reject the dummy packets. If the changes required in the relayer turn out to be extensive, they can be addressed as a separate issue. This will depend on whether the necessary components are available in both the
hermes-sdk
and Starknet’s relayer.(cc @soareschen for more insight into what might need to be done for the relayer.)
The text was updated successfully, but these errors were encountered: