Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ICS-23 in Cairo into the Comet contract #209

Open
Tracked by #164
Farhad-Shabani opened this issue Jan 20, 2025 · 1 comment
Open
Tracked by #164

Integrate ICS-23 in Cairo into the Comet contract #209

Farhad-Shabani opened this issue Jan 20, 2025 · 1 comment

Comments

@Farhad-Shabani
Copy link
Member

Comes after #208, as part of #164

Context

Integrate the implemented ICS-23 verification logic into the CometClientComponent and implement the verify_(non_)membership methods there.

This also includes adding integration tests in Cairo, and updating the relayer to incorporate the necessary commitment proofs from the Cosmos side when constructing packets. Without these proofs, the IBC handlers will reject the dummy packets. If the changes required in the relayer turn out to be extensive, they can be addressed as a separate issue. This will depend on whether the necessary components are available in both the hermes-sdk and Starknet’s relayer.
(cc @soareschen for more insight into what might need to be done for the relayer.)

@soareschen
Copy link
Collaborator

The main thing to consider is that the proofs should be in byte array. The other challenge is that the MerkleProof struct is originally encoded as protobuf. So we need to either implement protobuf decoding for MerkleProof in Cairo, or implement Cairo decoding for MerkleProof on the relayer. Compared to PacketData, this is simpler as the relayer do not need to treat the proofs as opaque data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants