Skip to content

[ICS02] Use Vec<u8> for HeaderAttribute instead of Any #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Farhad-Shabani opened this issue Jul 14, 2023 · 0 comments · Fixed by #766
Closed

[ICS02] Use Vec<u8> for HeaderAttribute instead of Any #764

Farhad-Shabani opened this issue Jul 14, 2023 · 0 comments · Fixed by #766
Assignees
Labels
S: specs Scope: related to IBC protocol specifications
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Problem Statement

Context: HeaderAttribute is a field of our UpdateClient event.

  • Taking ibc-go as a reference implementation and reviewing the suggested spec for events here, it appears that the header attribute was never intended to be of type Any, but rather to consist of hex-encoded raw Protobuf bytes.

  • Looking at Hermes too, this header is not used for parsing into a concrete header type anywhere.

  • This issue originated from Compile errors of v0.41.0 while only serde feature enabled #741, where enabling serde on HeaderAttribute with the Any type leads to a compilation error.

@Farhad-Shabani Farhad-Shabani added the S: specs Scope: related to IBC protocol specifications label Jul 14, 2023
@Farhad-Shabani Farhad-Shabani self-assigned this Jul 14, 2023
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Jul 14, 2023
@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Jul 14, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.43.0 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: specs Scope: related to IBC protocol specifications
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant