Skip to content

Put top-level validate() and execute() entrypoints under a feature flag #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
plafer opened this issue Apr 12, 2023 · 1 comment · Fixed by #661
Closed

Put top-level validate() and execute() entrypoints under a feature flag #613

plafer opened this issue Apr 12, 2023 · 1 comment · Fixed by #661
Assignees
@Farhad-Shabani
Labels
O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Milestone
v0.40.0

Comments

@plafer
Copy link
Contributor

plafer commented Apr 12, 2023 

          As a suggestion, couldn’t we just make `validate()` and `execute()` entrypoints hidden in the first place. Maybe, keeping them under a feature flag and only giving the access if a relevant feature is enabled?

Originally posted by @Farhad-Shabani in #584 (comment)
@plafer plafer mentioned this issue Apr 12, 2023
Merged
23 tasks
@Farhad-Shabani Farhad-Shabani moved this to 📥 To Do in ibc-rs Apr 13, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue May 5, 2023
Merged
7 tasks
@Farhad-Shabani Farhad-Shabani self-assigned this May 5, 2023
@Farhad-Shabani Farhad-Shabani moved this from 📥 To Do to 🏗️ In Progress in ibc-rs May 5, 2023
@Farhad-Shabani Farhad-Shabani added the O: usability Objective: aims to enhance user experience (UX) and streamline product usability label May 5, 2023
@plafer
Copy link
Contributor Author

plafer commented May 8, 2023

Closing as won't do, see comment. We can always revisit in the future.

@plafer plafer closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in ibc-rs May 8, 2023
@Farhad-Shabani Farhad-Shabani added this to the v0.40.0 milestone May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Farhad-Shabani Farhad-Shabani

Labels
O: usability Objective: aims to enhance user experience (UX) and streamline product usability
Projects
None yet
Milestone
v0.40.0
Development

Successfully merging a pull request may close this issue.

Separate handler methods from context APIs as free functions informalsystems/ibc-rs
2 participants
@plafer @Farhad-Shabani