Skip to content

Commit 62fbd14

Browse files
Update issue templates and CONTRIBUTING.md (#345)
* Update issue templates and CONTRIBUTING.md * Reflect review input * few edits Co-authored-by: Philippe Laferriere <[email protected]>
1 parent fba1aca commit 62fbd14

File tree

7 files changed

+98
-174
lines changed

7 files changed

+98
-174
lines changed

.github/ISSUE_TEMPLATE/bug-report.md

Lines changed: 7 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -5,34 +5,19 @@ about: Create a report to help us squash bugs!
55
---
66

77
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺
8-
v ✰ Thanks for opening an issue! ✰
8+
v ✰ Thanks for opening an issue! ✰
99
v Before smashing the submit button please review the template.
1010
v Please also ensure that this is not a duplicate issue :)
1111
☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->
1212

13-
## Summary of Bug
13+
## Bug Summary
1414

15-
<!-- Describe the issue you're encountering -->
15+
<!-- Provide a short description of the issue you're encountering -->
1616

17-
## Version
18-
19-
<!-- ibc-rs release version or git commit hash -->
20-
21-
## Steps to Reproduce
22-
23-
<!-- What commands should someone run to reproduce your problem? -->
24-
<!-- Attach logs here if you have them. -->
17+
## Details
2518

26-
## Acceptance Criteria
19+
<!-- Add details needed to reproduce the issue here -->
2720

28-
<!-- What's the definition of "done" for this issue? -->
29-
30-
____
31-
32-
## For Admin Use
21+
## Version
3322

34-
- [ ] Not duplicate issue
35-
- [ ] Appropriate labels applied
36-
- [ ] Appropriate milestone (priority) applied
37-
- [ ] Appropriate contributors tagged
38-
- [ ] Contributor assigned/self-assigned
23+
<!-- ibc-rs release version or git commit hash -->
Lines changed: 4 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,41 +1,20 @@
11
---
22
name: Feature Request
3-
about: Create a proposal to request a feature
3+
about: Create a proposal to request a feature!
44

55
---
66

77
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺
8-
v ✰ Thanks for opening an issue! ✰
8+
v ✰ Thanks for opening an issue! ✰
99
v Before smashing the submit button please review the template.
1010
v Word of caution: poorly thought-out proposals may be rejected
1111
v without deliberation
1212
☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->
1313

14-
## Summary
14+
## Feature Summary
1515

1616
<!-- Short description of the proposed feature -->
1717

18-
## Problem Definition
19-
20-
<!-- Why do we need this feature?
21-
What problems may be addressed by introducing this feature?
22-
What benefits does IBC-rs stand to gain by including this feature?
23-
Are there any disadvantages of including this feature? -->
24-
2518
## Proposal
2619

27-
<!-- Detailed description of requirements of implementation -->
28-
29-
## Acceptance Criteria
30-
31-
<!-- What's the definition of "done" for this issue? -->
32-
33-
____
34-
35-
#### For Admin Use
36-
37-
- [ ] Not duplicate issue
38-
- [ ] Appropriate labels applied
39-
- [ ] Appropriate milestone (priority) applied
40-
- [ ] Appropriate contributors tagged
41-
- [ ] Contributor assigned/self-assigned
20+
<!-- Provide a full description and requirements of the feature -->
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
---
2+
name: Process Improvement
3+
about: Create a proposal to suggest an improvement for `ibc-rs` operations!
4+
5+
---
6+
7+
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺
8+
v ✰ Thanks for opening an issue! ✰
9+
v Before smashing the submit button please review the template.
10+
v Please also ensure that this is not a duplicate issue :)
11+
☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->
12+
13+
## Improvement Summary
14+
15+
<!-- Short description of the proposed improvement about the projects' processes -->
16+
17+
## Proposal
18+
19+
<!-- Describe your proposal for how some process of `ibc-rs` should be improved -->
20+
<!-- What would be the benefits if we adopted the proposal?
21+
Are there any disadvantages? -->

.github/ISSUE_TEMPLATE/question.md

Lines changed: 0 additions & 30 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/release-template.md

Lines changed: 0 additions & 21 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/rust-update.md

Lines changed: 0 additions & 25 deletions
This file was deleted.

CONTRIBUTING.md

Lines changed: 66 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,10 @@ The rest of this document outlines the best practices for contributing to this
1515
repository:
1616

1717
- [Decision Making](#decision-making) - process for agreeing to changes
18+
- [Issues](#issues) - what makes a good issue
19+
- [Pull Requests](#pull-requests) - what makes a good pull request
1820
- [Forking](#forking) - fork the repo to make pull requests
1921
- [Changelog](#changelog) - changes must be recorded in the changelog
20-
- [Pull Requests](#pull-requests) - what makes a good pull request
2122
- [Releases](#releases) - how to release new version of the crates
2223

2324
## Decision Making
@@ -60,9 +61,67 @@ that PRs will sit open for long periods of time.
6061

6162
Each stage of the process is aimed at creating feedback cycles which align
6263
contributors and maintainers in order to ensure that:
64+
6365
- Contributors don’t waste their time implementing/proposing features which won’t land in `main`
6466
- Maintainers have the necessary context in order to support and review contributions
6567

68+
## Issues
69+
70+
We welcome bug reports, feature requests, and other contributions to our project. To open an issue, please follow these guidelines:
71+
72+
1. **Search existing issues**: Before opening a new issue, please search existing issues to ensure that is not a duplicates.
73+
74+
2. **Provide a clear and descriptive title**: This helps others understand the nature of the issue at a glance.
75+
76+
3. **Provide detailed information**: In the issue description, clearly state the purpose of the issue and follow the guidelines of the issue template
77+
78+
4. A maintainer will take care of assigning the appropriate labels to your issue.
79+
80+
We use the following convention for issue label names:
81+
- (WHY) The purpose or objective of this issue with Objective-level "O" labels like `O: security`, `O: new-feature`, etc.
82+
- (WHICH) The part of the system this issue relates to using:
83+
- External-level "E" labels if the issue fall outside the current scope of the system and is related to external dependencies or projects like `E: non-cosmos`, `E: no-std` etc.
84+
- or "Internal-level "I" labels for anything related to the current scope of the product like `I: errors`, `I: documentation`, etc.
85+
- (HOW) If any administrative considerations should be taken into account use Administrative-level "A" labels like `A: help-wanted`, `A: critical`, etc.
86+
87+
## Pull Requests
88+
89+
If you have write access to the ibc-rs repo, you can directly branch off of `main`.
90+
This makes it easier for project maintainers to directly make changes to your
91+
branch should the need arise. Otherwise, check [Forking](#forking) section for instructions.
92+
93+
Branch names should be prefixed with the author's name followed by a short description
94+
of the feature, eg. `name/feature-x`.
95+
96+
Pull requests are made against `main` and are squash-merged into main.
97+
98+
**PRs must:**
99+
100+
- make reference to an issue outlining the context
101+
- update any relevant documentation and include tests
102+
- add a corresponding entry in the `.changelog` directory using `unclog`,
103+
see the [Changelog](#changelog) section for more details.
104+
105+
Pull requests should aim to be small and self-contained to facilitate quick
106+
review and merging. Larger change sets should be broken up across multiple PRs.
107+
Commits should be concise but informative, and moderately clean. Commits will be squashed into a
108+
single commit for the PR with all the commit messages.
109+
110+
If the issue you worked on was tagged `A: low-priority`, we'll do our best to
111+
review it in a timely manner, but please expect longer wait times for a review
112+
in general. If a low priority issue is important to you, please leave a comment
113+
explaining why, and we will reprioritize it!
114+
115+
## Responsibilities of a PR Reviewer
116+
117+
If you're tagged as the reviewer of a PR, you are responsible for shepherding it
118+
through to completion. This includes fixing issues with the PR and taking the
119+
lead on decisions that need to be resolved in order to get the PR merged.
120+
121+
If you're tagged as a reviewer on a PR that affects a part of the code base that
122+
you are unfamiliar with, you can hand it off to someone (with their
123+
consent) who is more appropriate to shepherd the PR through to completion.
124+
66125
## Forking
67126

68127
If you do not have write access to the repository, your contribution should be
@@ -72,10 +131,11 @@ make a pull request back upstream.
72131

73132
When forking, add your fork's URL as a new git remote in your local copy of the
74133
repo. For instance, to create a fork and work on a branch of it:
134+
75135
- Create the fork on GitHub, using the fork button.
76136
- `cd` to the original clone of the repo on your machine
77137
- `git remote rename origin upstream`
78-
- `git remote add origin [email protected]:<location of fork>
138+
- `git remote add origin [email protected]:<location of fork>`
79139

80140
Now `origin` refers to your fork and `upstream` refers to the original version.
81141
Now `git push -u origin main` to update the fork, and make pull requests
@@ -104,13 +164,13 @@ Add a `.changelog` entry to signal that a bug was fixed, without mentioning any
104164
component.
105165

106166
```bash
107-
$ unclog add -i update-unclog-instructions -s bug -n 1634 -m "Update CONTRIBUTING.md for latest version of unclog" --editor vim
167+
unclog add -i update-unclog-instructions -s bug -n 1634 -m "Update CONTRIBUTING.md for latest version of unclog" --editor vim
108168
```
109169

110170
Add a .changelog entry for the `ibc` crate.
111171

112172
```bash
113-
$ unclog add -c ibc -s features --id a-new-feature --issue-no 1235 -m "msg about this new-feature" --editor vim
173+
unclog add -c ibc -s features --id a-new-feature --issue-no 1235 -m "msg about this new-feature" --editor vim
114174
```
115175

116176
### Preview unreleased changes
@@ -149,12 +209,12 @@ specific release number in Changelog.
149209

150210
Changelog entries should be formatted as follows:
151211

152-
```
212+
```md
153213
- [pkg] Some description about the change ([#xxx](https://github.com/cosmos/ibc-rs/issues/xxx)) (optional @contributor)
154214
```
155215

156216
Here, `pkg` is the part of the code that changed (typically a
157-
top-level crate, but could be <crate>/<module>), `xxx` is the issue number, and `contributor`
217+
top-level crate, but could be `<crate>/<module>`), `xxx` is the issue number, and `contributor`
158218
is the author/s of the change.
159219

160220
It's also acceptable for `xxx` to refer to the relevant pull request, but issue
@@ -174,48 +234,6 @@ instance, a change to some core protocol data structure might need to be
174234
reflected both as breaking the core protocol but also breaking any APIs where core data structures are
175235
exposed.
176236

177-
## Pull Requests
178-
179-
If you have write access to the ibc-rs repo, you can directly branch off of `main`.
180-
This makes it easier for project maintainers to directly make changes to your
181-
branch should the need arise.
182-
183-
Branch names should be prefixed with the author's name followed by a short description
184-
of the feature, eg. `name/feature-x`.
185-
186-
Pull requests are made against `main` and are squash-merged into main.
187-
188-
PRs must:
189-
- make reference to an issue outlining the context
190-
- update any relevant documentation and include tests
191-
- add a corresponding entry in the `.changelog` directory using `unclog`,
192-
see the section above for more details.
193-
194-
Pull requests should aim to be small and self-contained to facilitate quick
195-
review and merging. Larger change sets should be broken up across multiple PRs.
196-
Commits should be concise but informative, and moderately clean. Commits will be squashed into a
197-
single commit for the PR with all the commit messages.
198-
199-
In order to help facilitate the PR review process, tag *one* person as the
200-
reviewer of the PR. If you are unsure of who to tag, your point of contact on
201-
the ibc-rs team is always a natural candidate; they'll make sure that the PR gets
202-
reviewed by whomever is most appropriate to review it.
203-
204-
If the issue you worked on was tagged `A: low priority`, we'll do our best to
205-
review it in a timely manner, but please expect longer wait times for a review
206-
in general. If a low priority issue is important to you, please leave a comment
207-
explaining why, and we will reprioritize it!
208-
209-
## Responsibilities of a PR Reviewer
210-
211-
If you're tagged as the reviewer of a PR, you are responsible for shepherding it
212-
through to completion. This includes fixing issues with the PR and taking the
213-
lead on decisions that need to be resolved in order to get the PR merged.
214-
215-
If you're tagged as a reviewer on a PR that affects a part of the code base that
216-
you are unfamiliar with, you can hand it off to someone (with their
217-
consent) who is more appropriate to shepherd the PR through to completion.
218-
219237
## Releases
220238

221239
Our release process is as follows:
@@ -255,6 +273,3 @@ Our release process is as follows:
255273
`[📖CHANGELOG](https://github.com/cosmos/ibc-rs/blob/main/CHANGELOG.md#vXYZ)`
256274
to the release description.
257275
11. All done! 🎉
258-
259-
[crates.io]: https://crates.io
260-
[crates.io-security]: https://codeandbitters.com/published-crate-analysis/

0 commit comments

Comments
 (0)