Add BigInt support and more nj-core support for N-API v7. (#97)

simlay · web-flow · commit 37a9ca45c80b · 2020-10-26T12:00:00.000-07:00
* Update to N-API v7 and add BigInt support.

* Updated to N-API v7 in nj-sys.
* Updated CHANGELOG.
* Added detach buffer calls in JsEnv.
* Added BigInt for going to-from rust and JS.
* Re-export the rust bigint exports.

* Update from comment
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,14 @@
 # Changelog
 
+## Unreleased
+- Support for converting to/from [Rust BigInt][rust-bigint] to/from [JavaScript BigInt][js-bigint] ([#97][]).
+- Support for converting Rust `u64` to BigInt in JavaScript. ([#97][])
+- Updated to N-API v7 in `js-sys`. ([#97][])
+
+[rust-bigint]: https://crates.io/crates/num-bigint
+[js-bigint]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt
+[#97]: https://github.com/infinyon/node-bindgen/pull/97
+
 ## [3.0.0] - 2020-10-14-2000
 - Support for Passing Buffer to Rust
 - Support for Env cleanup
@@ -11,7 +20,7 @@
 - Support for Array [#26](https://github.com/infinyon/node-bindgen/pull/26)
 
 ## Fixed
-- Fixed conversion of () [#31](https://github.com/infinyon/node-bindgen/pull/31)
+- Fixed conversion of `()` [#31](https://github.com/infinyon/node-bindgen/pull/31)
 
 # [2.0.0] - 2020-05-011
 
@@ -21,4 +30,4 @@
 
 ## Fixed
 
-- Proper support for boolean [#19](https://github.com/infinyon/node-bindgen/pull/19)
+- Proper support for boolean [#19](https://github.com/infinyon/node-bindgen/pull/19)
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/examples/Cargo.lock b/examples/Cargo.lock
diff --git a/examples/Cargo.toml b/examples/Cargo.toml
@@ -14,8 +14,9 @@ members = [
     "buffer",
     "array",
     "electron",
-    "cleanup"
+    "cleanup",
+    "bigint",
 ]
 
 #[patch.crates-io]
-#flv-future-aio = { path = "../../flv-future/src/future-aio"}
+#flv-future-aio = { path = "../../flv-future/src/future-aio"}
diff --git a/examples/Makefile b/examples/Makefile
@@ -11,11 +11,13 @@ clean:
 	make -C class-async clean
 	make -C param clean
 	make -C electron clean
+	make -C bigint clean
 	make -C cleanup clean
 
 
 test: test-function test-cb test-async-cb test-promise test-json test-class-simple \
-	test-class-wrapper test-class-async test-stream test-buffer test-array test-cleanup
+	test-class-wrapper test-class-async test-stream test-buffer test-array test-bigint \
+	test-cleanup
 
 test-function:
 	make -C function test
@@ -56,5 +58,8 @@ test-array:
 test-electron:
 	make -C electron test
 
+test-bigint:
+	make -C bigint test
+
 test-cleanup:
-	make -C cleanup test
+	make -C cleanup test
diff --git a/examples/bigint/.gitignore b/examples/bigint/.gitignore
@@ -0,0 +1 @@
+dist
diff --git a/examples/bigint/Cargo.toml b/examples/bigint/Cargo.toml
@@ -0,0 +1,17 @@
+[package]
+name = "nj-example-bigint"
+version = "0.1.0"
+authors = ["fluvio.io"]
+edition = "2018"
+
+
+[lib]
+crate-type = ["cdylib"]
+
+
+[dependencies]
+node-bindgen = { path = "../.."}
+
+
+[build-dependencies]
+node-bindgen = { path = "../../", features = ["build"] }
diff --git a/examples/bigint/Makefile b/examples/bigint/Makefile
@@ -0,0 +1,12 @@
+all:	build
+
+build:
+	nj-cli build
+
+test:	build
+	node test.js
+
+
+clean:
+	rm -rf dist
+
diff --git a/examples/bigint/README.md b/examples/bigint/README.md
@@ -0,0 +1 @@
+manual JS callback
diff --git a/examples/bigint/build.rs b/examples/bigint/build.rs
@@ -0,0 +1,3 @@
+fn main() {
+    node_bindgen::build::configure();
+}
diff --git a/examples/bigint/src/lib.rs b/examples/bigint/src/lib.rs
@@ -0,0 +1,30 @@
+use node_bindgen::derive::node_bindgen;
+use node_bindgen::core::bigint::BigInt;
+
+// example where we multiply a big_int.
+#[node_bindgen]
+fn multiply_big_int(arg: BigInt) -> BigInt {
+    println!("bigint arg: {}", arg);
+    arg*2
+}
+
+// Test that we can go across the FFI without screwing up the bits.
+#[node_bindgen]
+fn do_nothing(arg: BigInt) -> BigInt {
+    println!("bigint arg: {}", arg);
+    arg
+}
+
+// Test out the signage conversion
+#[node_bindgen]
+fn go_negative(arg: BigInt) -> BigInt {
+    println!("bigint arg: {}", arg);
+    -1*arg
+}
+
+// Test out that we can return a u64 which is automatically converted to a bigint.
+#[node_bindgen]
+fn return_u64(arg: u32) -> u64 {
+    println!("bigint arg: {}", arg);
+    arg as u64
+}
diff --git a/examples/bigint/test.js b/examples/bigint/test.js
@@ -0,0 +1,22 @@
+const assert = require('assert');
+
+let addon = require('./dist');
+
+const hugeBin = BigInt("0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF")
+
+// Test that we can go back and forth through the FFI
+assert.equal(addon.doNothing(hugeBin), hugeBin);
+
+// Test out some signage
+assert.equal(addon.goNegative(hugeBin), hugeBin*BigInt(-1));
+
+// How about multiplication?
+assert.equal(addon.multiplyBigInt(hugeBin), hugeBin*(BigInt(2)));
+
+// Basic tests from js-env
+assert.equal(addon.multiplyBigInt(BigInt(-5)), BigInt(-10));
+assert.equal(addon.multiplyBigInt(BigInt(5)), BigInt(10));
+assert.equal(addon.multiplyBigInt(BigInt(5)), BigInt(10));
+
+// Rust's u64s turn into JS BigInts.
+assert.equal(addon.returnU64(5), BigInt(5));
diff --git a/examples/js-env/src/lib.rs b/examples/js-env/src/lib.rs
@@ -9,8 +9,8 @@ use node_bindgen::core::val::JsEnv;
 /// JsEnv argument does not manipulate JsCb arguments
 #[node_bindgen]
 fn multiply(env: JsEnv, arg: f64) -> Result<napi_value, NjError> {
-    
+
     println!("arg: {}",arg);
     env.create_double(arg * 2.0)
-} 
+}
 
diff --git a/examples/js-env/test.js b/examples/js-env/test.js
@@ -2,4 +2,4 @@ const assert = require('assert');
 
 let addon = require('./dist');
 
-assert.equal(addon.multiply(5),10);
+assert.equal(addon.multiply(5), 10);
diff --git a/nj-core/Cargo.toml b/nj-core/Cargo.toml
@@ -21,3 +21,4 @@ futures-lite = "1.7.0"
 nj-sys = { version = "1.0.0", path = "../nj-sys" }
 fluvio-future = { version = "0.1.0", default-features=false, features=["task","subscriber"]}
 pin-utils = "0.1.0"
+num-bigint = "0.3.0"
diff --git a/nj-core/src/basic.rs b/nj-core/src/basic.rs
@@ -154,6 +154,18 @@ impl JsEnv {
         Ok(result)
     }
 
+    pub fn create_bigint_uint64(&self, value: u64) -> Result<napi_value,NjError> {
+        let mut result = ptr::null_mut();
+        napi_call_result!(
+            crate::sys::napi_create_bigint_uint64(
+                self.0,
+                value,
+                &mut result
+            )
+        )?;
+        Ok(result)
+    }
+
     pub fn create_object(&self) -> Result<napi_value,NjError>  {
 
         let mut result = ptr::null_mut();
@@ -725,6 +737,27 @@ impl JsEnv {
 
     }
 
+    /// Detach ArrayBuffer
+    pub fn detach_arraybuffer(&self, napi_value: napi_value) -> Result<(),NjError> {
+        napi_call_result!(
+            crate::sys::napi_detach_arraybuffer(self.inner(), napi_value)
+        )?;
+        Ok(())
+    }
+
+    /// Is this ArrayBuffer Detached?
+    pub fn is_detached_arraybuffer(&self, napi_value: napi_value) -> Result<bool,NjError> {
+        let mut is_detached = false;
+        napi_call_result!(
+            crate::sys::napi_is_detached_arraybuffer(
+                self.inner(),
+                napi_value,
+                &mut is_detached,
+                )
+        )?;
+        Ok(is_detached)
+    }
+
     #[allow(unused_unsafe)]
     #[allow(clippy::missing_safety_doc)]
     pub unsafe fn add_env_clean_up_hook(
diff --git a/nj-core/src/bigint.rs b/nj-core/src/bigint.rs
diff --git a/nj-core/src/convert.rs b/nj-core/src/convert.rs
diff --git a/nj-core/src/lib.rs b/nj-core/src/lib.rs

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+fn main() {`
	`2`	`+ node_bindgen::build::configure();`
	`3`	`+}`