Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position property not working, fix not included in release #220

Open
dglaser-chwy opened this issue Oct 9, 2017 · 3 comments
Open

Position property not working, fix not included in release #220

dglaser-chwy opened this issue Oct 9, 2017 · 3 comments

Comments

@dglaser-chwy
Copy link

This issue has also been brought up in #201

I am not able to get the position property to work for any of the positions listed in the documentation, 'top right, bottom right, top left, bottom left'. It appears that a change to fix this was committed on May 17th but the code has not been included in a release yet. This is causing issues where the position fix is not being added to the dist folder as @vivekvenkatachari has noticed. @indrimuska If possible could your change on May 17 be added to a new release?

@longedok
Copy link

Same issue here, the fix from that commit on may 17th doesn't seem to work even after manually rebuilding the sources - the position function exits after the first condition, since the "position" property is set on the directive.

@oriamd
Copy link

oriamd commented Jan 21, 2018

Any Fix found for this?

@indrimuska
Copy link
Owner

Sorry for the late response, I will release a new version in a couple of minutes.

indrimuska added a commit that referenced this issue Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants