test updates

Author: imrehg

src/linkhub_prometheus_exporter/config.py

@@ -5,7 +5,7 @@
     settings_files=["settings.toml", ".secrets.toml"],
     # Validating and setting defaults
     validators=[
-        Validator("REQUEST_KEY", is_type_of=str, must_exist=True),
+        Validator("REQUEST_KEY", is_type_of=str),
         Validator("POLLING_INTERVAL_SECONDS", is_type_of=int, default=5),
         Validator("BOX_ADDRESS", is_type_of=str, default="192.168.1.1"),
         Validator("EXPORTER_PORT", is_type_of=int, default=9877),

src/linkhub_prometheus_exporter/exporter.py

@@ -145,11 +145,17 @@ def main():
     """Main entry point for the exporter"""
     logging.info("Linkhub Prometheus Exporter, version %s", __version__)
 
-    router_metrics = RouterMetrics(
-        request_key=settings.REQUEST_KEY,
-        box_addr=settings.BOX_ADDRESS,
-        polling_interval_seconds=settings.POLLING_INTERVAL_SECONDS,
-    )
+    try:
+        router_metrics = RouterMetrics(
+            request_key=settings.REQUEST_KEY,
+            box_addr=settings.BOX_ADDRESS,
+            polling_interval_seconds=settings.POLLING_INTERVAL_SECONDS,
+        )
+    except AttributeError as exc:
+        # Every other setting besides REQUEST_KEY has defaults
+        logging.error("Missing REQUEST_KEY configuration.")
+        raise RuntimeError("Missing REQUEST_KEY configuration.") from exc
+
     start_http_server(
         port=settings.EXPORTER_PORT, addr=settings.EXPORTER_ADDRESS
     )

tests/test_basic.py

@@ -4,6 +4,7 @@
 from linkhub_prometheus_exporter.exporter import RouterMetrics
 
 # Test payload data
+# Exported & modified from real requests
 NETWORK_INFO = {
     "PLMN": "12345",
     "NetworkType": 8,