Upgrade to 1.5.1

[sairamgeethanath]

Hi @btasdelen: I noticed you are working on porting to 1.5.0. Please let me know if you have or are planning to merge soon. I see that there is a 1.5.1 out, so I was planning to spend some time on porting as well, but will do so after you have done your PR.

[mcencini]

Hi @sairamgeethanath, I did port some of the 1.5.1 features (rotation and rf shimming extensions). When 1.5.0 is ready, we could start from there if you want, to avoid duplicated effort :D

[sairamgeethanath]

That sounds great, @mcencini! Thanks so much for this wonderful effort. I was getting asked a bit on the timeline so thought I will clear some time for it. Please also checkout this blurb for potential future directions here

[btasdelen]

@mcencini undertook the entirety of the effort for 1.5.0 and 1.5.1. We just need to test/review several relevant PRs and merge them.

[sairamgeethanath]

@mcencini - please let me know if you need any help. My student (@LeoMcBills) and I are happy to help if required, so we can put this out fairly quickly. Second, we also want to switch the license to something closer to MIT so downstream folks (read - interpreter implementers and vendors) dont have issues with adoption.

[mcencini]

Hi! I think PR #308 will introduce some conflicting changes to the plotting tools, which I also updated to support v1.5.x and align with MATLAB toolbox. Hence, it is maybe best to wait until it is merged (@schuenke), then fix the conflict with the v1.5.0_dev branch and then we can convert #319 draft to PR.

#319 should probably need some testing on the scanner, as I do not have a Siemens platform to test on. Then, we can move to 1.5.1, starting from rotations which I think is the most anticipated new feature (@wtclarke). I did split the 1.5.1 rotation implementation in two parts - one updates the gradient continuity check to align with MATLAB toolbox and enable the check in presence of rotation, and the second one implements the actual rotation extension, including plotting and waveforms_export() -like support.

It is not directly related to rotation extension, but maybe #302 could be merged together with these 1.5.1 updates. Does that sounds like a good plan (@btasdelen, @schuenke, @FrankZijlstra)?

EDIT: I am totally in favor of switching to MIT license - I already commented on #324

[schuenke]

#308 should be ready to merge now and afterwards I am happy to help with any potential merge conflicts in the plot function.

[wtclarke]

Hi All, Its great to see how much progress there has been. If you need any help testing things for 1.5.0/1.5.1 then I and a couple of members of my group would be very keen to help (we are very keen to get thing like the rotation matrix interface working).

[sairamgeethanath]

@wtclarke - Pypulseq is community-sustained. Please feel free to help us improve code coverage on both releases.

[wtclarke]

Indeed, I guess I was asking if there was anything specific that you could point us towards where effort would be most appreciated.