Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release with new ESLint types? #3133

Open
djahandarie opened this issue Dec 28, 2024 · 9 comments
Open

Release with new ESLint types? #3133

djahandarie opened this issue Dec 28, 2024 · 9 comments

Comments

@djahandarie
Copy link

Hiya, like many projects my project is upgrading to the new flat eslint config format. Unfortunately the eslint.config.js doesn't type check properly currently:

Module '"/home/darius/yomitan/node_modules/eslint-plugin-import/lib/index"' has no default export.ts(1192)

I believe the types added around two months ago here 9d1f639 should solve this issue.

Is there any chance we could get a new release with that included? I think probably a lot of mixed javascript / typescript projects will face this issue.

@michaelfaith
Copy link
Contributor

Can you try importing with * as (e.g. import * as importPlugin from 'eslint-plugin-import')

@ljharb
Copy link
Member

ljharb commented Dec 28, 2024

That commit indeed isn't released yet. there's a number of open PRs i'm hoping to get into it, but I'll try to cut one in the next couple days.

@pablobirukov
Copy link

@ljharb sorry for being "that guy", but I think there is a bunch of people who would appreciate a new version being released 🥺

@Dinhero21
Copy link

Dinhero21 commented Feb 8, 2025

Can you try importing with * as (e.g. import * as importPlugin from 'eslint-plugin-import')

worked for me, although differs from official documentation

using

// even though default export works, ts doesn't like it
import * as importPlugin from 'eslint-plugin-import';

in my projects

@michaelfaith
Copy link
Contributor

The official documentation doesn't cover using the plugin in a typescript based config at all. Feel free to submit a pr.

@jirimoravcik
Copy link

jirimoravcik commented Mar 5, 2025

Hello @ljharb,
this package is amazing, I would like to thank you for maintaining it.
The only thing slowing us is new versions not being released quickly.
Would you be interested if I created a PR that would introduce automatic beta releases with each commit?
That way early adopters could use the beta versions and the official latest releases would still be done manually.
Thank you for considering this.

@ljharb
Copy link
Member

ljharb commented Mar 5, 2025

No thanks; released is released, and automatic releases of any kind aren’t something I’m interested in.

@RigoOnRails
Copy link

@ljharb Think about it! Automatic releases equals more frequent downloads to your million packages! 😄

@ljharb
Copy link
Member

ljharb commented Mar 16, 2025

That's not a motivator; my time triaging issues, however, is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

8 participants