Skip to content

[SDK-3435] build and test ios #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Conversation

andrew-yangy
Copy link
Collaborator

Summary

Customer Impact

Added

Changed

Deprecated

Removed

Fixed

Security

Things worth calling out

Other things to consider:

  • Sample app is updated with new SDK changes
  • Updated public documentation with new SDK changes (Immutable X and Immutable zkEVM)
  • Sample game is updated with new SDK changes
  • Replied to GitHub issues

@andrew-yangy andrew-yangy requested a review from a team November 15, 2024 04:23
@@ -26,7 +26,7 @@ source: pytest-browserstack:sample-sdk:v1.0
# Set `app` to define the app that is to be used for testing.
# It can either take the id of any uploaded app or the path of the app directly.
#app: ./WikipediaSample.apk
app: ./Payload.ipa #For running local tests
app: ../build/output/iOS/IPA/Payload.ipa #For running local tests
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nattb8 Im sure it's not Payload.ipa but I don't know what it is, need to change

nattb8
nattb8 previously approved these changes Nov 15, 2024
@andrew-yangy andrew-yangy merged commit 3a9ea09 into main Nov 15, 2024
9 of 10 checks passed
@andrew-yangy andrew-yangy deleted the feature/sdk-3435-ios-build branch November 15, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants