Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented "global" vars #17

Open
ehrenfeu opened this issue Aug 12, 2024 · 2 comments · Fixed by #30
Open

Undocumented "global" vars #17

ehrenfeu opened this issue Aug 12, 2024 · 2 comments · Fixed by #30
Assignees
Labels
blocked Blocked by another issue / PR documentation Missing documentation, docstring conventions, ...
Milestone

Comments

@ehrenfeu
Copy link
Member

Lines like these ones

SINGLE_FILE = "[NO (one %s)]"
MULTI_SINGLE_FILE = "[YES (all %ss in one file)]"
MULTI_MULTI_FILE = "[YES (one file per %s)]"

should have:

  • either proper "variable docstrings" (usually preferred)
  • or be explicitly excluded from the API docs by adding a """@private""" pseudo-docstring (see lines 21 to 24 in the same file)

Pinging @lguerard

@ehrenfeu ehrenfeu added the documentation Missing documentation, docstring conventions, ... label Oct 30, 2024
@lguerard lguerard mentioned this issue Nov 6, 2024
ehrenfeu pushed a commit that referenced this issue Nov 12, 2024
@ehrenfeu
Copy link
Member Author

Hum, I think after looking at the rendered API docs I changed my mind once again:

Having the global vars documented doesn't really add value to the API docs, but instead rather clutters them up quite a bit (the module already has a lot of things anyway).

Especially since they're NOT meant to be imported / used in code other than this very module itself (bdv), I think it's preferable to use the """@private""" notation mentioned above to exclude them from the docs.

Here's a screenshot of the docs rendered for 1.5.0.a16:

Image

@ehrenfeu ehrenfeu reopened this Feb 14, 2025
@ehrenfeu ehrenfeu added this to the 1.5.0 milestone Feb 14, 2025
@ehrenfeu ehrenfeu self-assigned this Feb 14, 2025
@ehrenfeu ehrenfeu linked a pull request Mar 14, 2025 that will close this issue
@ehrenfeu ehrenfeu added the blocked Blocked by another issue / PR label Mar 20, 2025
@ehrenfeu
Copy link
Member Author

ehrenfeu commented Mar 20, 2025

The modifications requested in my previous comment should only be done AFTER #39 has been completed and merged!

Added label blocked to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by another issue / PR documentation Missing documentation, docstring conventions, ...
Projects
None yet
1 participant