Skip to content

Commit 026dcc7

Browse files
authored
Merge pull request #63 from imagekit-developer/dev
Dev
2 parents 950f385 + 37d8d5d commit 026dcc7

File tree

4 files changed

+26
-26
lines changed

4 files changed

+26
-26
lines changed

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "imagekit-javascript",
3-
"version": "1.5.2",
3+
"version": "1.5.3",
44
"description": "Javascript SDK for using ImageKit.io in the browser",
55
"main": "dist/imagekit.cjs.js",
66
"module": "dist/imagekit.esm.js",

src/url/builder.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ export const buildURL = (opts: UrlOptions & ImageKitOptions) => {
4343
return "";
4444
}
4545

46-
if (opts.sdkVersion && opts.sdkVersion.trim() != "") {
47-
urlObj.searchParams.append("ik-sdk-version", opts.sdkVersion.trim());
48-
}
46+
// if (opts.sdkVersion && opts.sdkVersion.trim() != "") {
47+
// urlObj.searchParams.append("ik-sdk-version", opts.sdkVersion.trim());
48+
// }
4949

5050
for (var i in opts.queryParameters) {
5151
urlObj.searchParams.append(i, String(opts.queryParameters[i]));

test/url-generation.js

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,15 @@ describe("URL generation", function () {
2626
path: "/test_path.jpg"
2727
});
2828

29-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
29+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/test_path.jpg`);
3030
});
3131

3232
it('no transformation src', function () {
3333
const url = imagekit.url({
3434
src: "https://ik.imagekit.io/test_url_endpoint/test_path_alt.jpg"
3535
});
3636

37-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/test_path_alt.jpg?ik-sdk-version=javascript-${pkg.version}`);
37+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/test_path_alt.jpg`);
3838
});
3939

4040
it('Undefined parameters with path', function () {
@@ -45,7 +45,7 @@ describe("URL generation", function () {
4545
src: undefined,
4646
});
4747

48-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/test_path_alt.jpg?ik-sdk-version=javascript-${pkg.version}`);
48+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/test_path_alt.jpg`);
4949
});
5050

5151
it('should generate the url without sdk-version', function () {
@@ -71,7 +71,7 @@ describe("URL generation", function () {
7171
}]
7272
});
7373

74-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
74+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400/test_path.jpg`);
7575
});
7676

7777
it('should generate the correct url with path param with multiple leading slash', function () {
@@ -83,7 +83,7 @@ describe("URL generation", function () {
8383
}]
8484
})
8585

86-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
86+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400/test_path.jpg`);
8787

8888
});
8989

@@ -97,7 +97,7 @@ describe("URL generation", function () {
9797
}]
9898
})
9999

100-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint_alt/tr:h-300,w-400/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
100+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint_alt/tr:h-300,w-400/test_path.jpg`);
101101

102102
});
103103

@@ -111,7 +111,7 @@ describe("URL generation", function () {
111111
}]
112112
});
113113

114-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/test_path.jpg?ik-sdk-version=javascript-${pkg.version}&tr=h-300%2Cw-400`);
114+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/test_path.jpg?tr=h-300%2Cw-400`);
115115
});
116116

117117
it('should generate the correct url with src param', function () {
@@ -123,7 +123,7 @@ describe("URL generation", function () {
123123
}]
124124
});
125125

126-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/test_path_alt.jpg?ik-sdk-version=javascript-${pkg.version}&tr=h-300%2Cw-400`);
126+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/test_path_alt.jpg?tr=h-300%2Cw-400`);
127127
});
128128

129129
it('should generate the correct url with transformationPostion as query', function () {
@@ -136,7 +136,7 @@ describe("URL generation", function () {
136136
}]
137137
});
138138

139-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/test_path_alt.jpg?ik-sdk-version=javascript-${pkg.version}&tr=h-300%2Cw-400`);
139+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/test_path_alt.jpg?tr=h-300%2Cw-400`);
140140
});
141141

142142
it('should generate the correct url with query params properly merged', function () {
@@ -149,7 +149,7 @@ describe("URL generation", function () {
149149
}]
150150
});
151151

152-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/test_path_alt.jpg?t1=v1&ik-sdk-version=javascript-${pkg.version}&t2=v2&t3=v3&tr=h-300%2Cw-400`);
152+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/test_path_alt.jpg?t1=v1&t2=v2&t3=v3&tr=h-300%2Cw-400`);
153153
});
154154

155155

@@ -164,7 +164,7 @@ describe("URL generation", function () {
164164
}]
165165
})
166166

167-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400:rt-90/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
167+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400:rt-90/test_path.jpg`);
168168
});
169169

170170

@@ -179,7 +179,7 @@ describe("URL generation", function () {
179179
}]
180180
})
181181

182-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400:rndm_trnsf-abcd/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
182+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400:rndm_trnsf-abcd/test_path.jpg`);
183183
});
184184

185185
it('overlayImage', function () {
@@ -192,7 +192,7 @@ describe("URL generation", function () {
192192
}]
193193
})
194194

195-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400,oi-overlay.jpg/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
195+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400,oi-overlay.jpg/test_path.jpg`);
196196
});
197197

198198
it('overlayImage with slash in path', function () {
@@ -205,7 +205,7 @@ describe("URL generation", function () {
205205
}]
206206
})
207207

208-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400,oi-path@@to@@overlay.jpg/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
208+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400,oi-path@@to@@overlay.jpg/test_path.jpg`);
209209
});
210210

211211
it('overlayX', function () {
@@ -218,7 +218,7 @@ describe("URL generation", function () {
218218
}]
219219
})
220220

221-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400,ox-10/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
221+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400,ox-10/test_path.jpg`);
222222
});
223223

224224
it('Border', function () {
@@ -231,7 +231,7 @@ describe("URL generation", function () {
231231
}]
232232
})
233233

234-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400,b-20_FF0000/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
234+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400,b-20_FF0000/test_path.jpg`);
235235
});
236236

237237
it('transformation with empty key and empty value', function () {
@@ -242,7 +242,7 @@ describe("URL generation", function () {
242242
}]
243243
})
244244

245-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:-/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
245+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:-/test_path.jpg`);
246246
});
247247

248248
/**
@@ -256,7 +256,7 @@ describe("URL generation", function () {
256256
}]
257257
})
258258

259-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:undefined-transform-true/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
259+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:undefined-transform-true/test_path.jpg`);
260260
});
261261

262262
it('transformation with empty value', function () {
@@ -267,7 +267,7 @@ describe("URL generation", function () {
267267
}]
268268
})
269269

270-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:oi-/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
270+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:oi-/test_path.jpg`);
271271
});
272272

273273
it('transformation with - value', function () {
@@ -278,7 +278,7 @@ describe("URL generation", function () {
278278
}]
279279
})
280280

281-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:e-contrast/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
281+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:e-contrast/test_path.jpg`);
282282
});
283283

284284
it('All combined', function () {
@@ -341,7 +341,7 @@ describe("URL generation", function () {
341341
}]
342342
})
343343

344-
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400,ar-4-3,q-40,c-force,cm-extract,fo-left,f-jpeg,r-50,bg-A94D34,b-5-A94D34,rt-90,bl-10,n-some_name,ox-35,oy-35,ofo-bottom,oh-20,ow-20,oi-folder@@file.jpg,oit-false,oiar-4:3,oibg-0F0F0F,oib-10_0F0F0F,oidpr-2,oiq-50,oic-force,ot-two%20words,ots-20,otf-Open%20Sans,otc-00FFFF,oa-5,ott-b,obg-00AAFF55,ote-b3ZlcmxheSBtYWRlIGVhc3k%3D,otw-50,otbg-00AAFF55,otp-40,otia-left,or-10,pr-true,lo-true,t-5,md-true,cp-true,di-folder@@file.jpg,dpr-3,e-sharpen-10,e-usm-2-2-0.8-0.024,e-contrast-true,e-grayscale-true,orig-true,h-200,w-300,l-image,i-logo.png,l-end/test_path.jpg?ik-sdk-version=javascript-${pkg.version}`);
344+
expect(url).equal(`https://ik.imagekit.io/test_url_endpoint/tr:h-300,w-400,ar-4-3,q-40,c-force,cm-extract,fo-left,f-jpeg,r-50,bg-A94D34,b-5-A94D34,rt-90,bl-10,n-some_name,ox-35,oy-35,ofo-bottom,oh-20,ow-20,oi-folder@@file.jpg,oit-false,oiar-4:3,oibg-0F0F0F,oib-10_0F0F0F,oidpr-2,oiq-50,oic-force,ot-two%20words,ots-20,otf-Open%20Sans,otc-00FFFF,oa-5,ott-b,obg-00AAFF55,ote-b3ZlcmxheSBtYWRlIGVhc3k%3D,otw-50,otbg-00AAFF55,otp-40,otia-left,or-10,pr-true,lo-true,t-5,md-true,cp-true,di-folder@@file.jpg,dpr-3,e-sharpen-10,e-usm-2-2-0.8-0.024,e-contrast-true,e-grayscale-true,orig-true,h-200,w-300,l-image,i-logo.png,l-end/test_path.jpg`);
345345
});
346346
});
347347

0 commit comments

Comments
 (0)