addressed the feedbacks

ANKUR DWIVEDI · ANKUR DWIVEDI · commit f0828466d55c · 2024-04-23T14:39:02.000+05:30
diff --git a/sdk/projects/imagekitio-angular/src/lib/ik-image/ik-image.component.ts b/sdk/projects/imagekitio-angular/src/lib/ik-image/ik-image.component.ts
@@ -1,5 +1,5 @@
 import { Component, AfterViewInit, OnInit, ElementRef, Input, OnChanges } from '@angular/core';
-import { ImagekitioAngularService } from '../imagekitio-angular.service';
+import { ImagekitService } from '../imagekitio-angular.service';
 import { Dict, QueryParameters, IkImageComponentOptions, LqipOptions } from '../utility/ik-type-def-collection'
 import { Transformation } from 'imagekit-javascript/dist/src/interfaces/Transformation';
 
@@ -21,7 +21,7 @@ export class IkImageComponent implements AfterViewInit, OnInit, OnChanges {
   
   observer: MutationObserver;
 
-  constructor(private el: ElementRef, private imagekit: ImagekitioAngularService) {
+  constructor(private el: ElementRef, private imagekit: ImagekitService) {
   }
 
   ngOnInit(): void {
diff --git a/sdk/projects/imagekitio-angular/src/lib/ik-upload/ik-upload.component.ts b/sdk/projects/imagekitio-angular/src/lib/ik-upload/ik-upload.component.ts
@@ -1,5 +1,5 @@
 import { AfterViewInit, ElementRef, Component, Input, Output, EventEmitter } from '@angular/core';
-import { ImagekitioAngularService } from '../imagekitio-angular.service';
+import { ImagekitService } from '../imagekitio-angular.service';
 import { IkUploadComponentOptions, Dict, HTMLInputEvent } from '../utility/ik-type-def-collection';
 
 @Component({
@@ -10,7 +10,7 @@ import { IkUploadComponentOptions, Dict, HTMLInputEvent } from '../utility/ik-ty
     <input type="file" (change)="handleFileInput($event)" />
   </ng-template>
   `,
-  providers: [ImagekitioAngularService]
+  providers: [ImagekitService]
 })
 export class IkUploadComponent implements AfterViewInit {
   @Input('fileName') fileName: string; //optional
@@ -40,7 +40,7 @@ export class IkUploadComponent implements AfterViewInit {
   fileToUpload: File = null;
   xhr: XMLHttpRequest;
 
-  constructor(private el: ElementRef, private imagekit: ImagekitioAngularService) { 
+  constructor(private el: ElementRef, private imagekit: ImagekitService) { 
   }
   
   ngAfterViewInit():void {
@@ -155,7 +155,7 @@ export class IkUploadComponent implements AfterViewInit {
       this.urlEndpoint === undefined ){
         return this.imagekit.ikInstance;
     }
-    return new ImagekitioAngularService({
+    return new ImagekitService({
       urlEndpoint: this.urlEndpoint,
       publicKey: this.publicKey,
     })._ikInstance
diff --git a/sdk/projects/imagekitio-angular/src/lib/ik-video/ik-video.component.ts b/sdk/projects/imagekitio-angular/src/lib/ik-video/ik-video.component.ts
@@ -1,5 +1,5 @@
 import { Component, OnInit, ElementRef, Input } from '@angular/core';
-import { ImagekitioAngularService } from '../imagekitio-angular.service';
+import { ImagekitService } from '../imagekitio-angular.service';
 import { IkVideoComponentOptions, QueryParameters, Dict } from '../utility/ik-type-def-collection'
 import { Transformation } from 'imagekit-javascript/dist/src/interfaces/Transformation';
 
@@ -18,7 +18,7 @@ export class IkVideoComponent implements OnInit {
   @Input('queryParameters') queryParameters: QueryParameters;
   url = '';
 
-  constructor(private el: ElementRef, private imagekit: ImagekitioAngularService) { }
+  constructor(private el: ElementRef, private imagekit: ImagekitService) { }
 
   ngOnInit(): void {
     const options: IkVideoComponentOptions =  this.src ? {src: this.src} : {path: this.path};
diff --git a/sdk/projects/imagekitio-angular/src/lib/imagekitio-angular.module.ts b/sdk/projects/imagekitio-angular/src/lib/imagekitio-angular.module.ts
@@ -1,9 +1,9 @@
+import { CommonModule } from '@angular/common';
 import { ModuleWithProviders, NgModule } from '@angular/core';
-import { ImageKitConfiguration } from './imagekitio-angular.service';
 import { IkImageComponent } from './ik-image/ik-image.component';
-import { IkVideoComponent } from './ik-video/ik-video.component';
 import { IkUploadComponent } from './ik-upload/ik-upload.component';
-import { CommonModule } from '@angular/common';
+import { IkVideoComponent } from './ik-video/ik-video.component';
+import { ImageKitConfiguration, ImagekitService } from './imagekitio-angular.service';
 
 @NgModule({
   declarations: [
@@ -16,7 +16,8 @@ import { CommonModule } from '@angular/common';
     IkImageComponent,
     IkVideoComponent,
     IkUploadComponent
-  ]
+  ],
+  providers: [ ImagekitService ]
 })
 export class ImagekitioAngularModule { 
   static forRoot(config: ImageKitConfiguration): ModuleWithProviders<ImagekitioAngularModule> {
diff --git a/sdk/projects/imagekitio-angular/src/lib/imagekitio-angular.service.ts b/sdk/projects/imagekitio-angular/src/lib/imagekitio-angular.service.ts
@@ -7,8 +7,8 @@ export interface Lqip {
 }
 
 export class ImageKitConfiguration {
-  urlEndpoint: string ='';
-  publicKey: string ='';
+  urlEndpoint: string;
+  publicKey: string;
   authenticator?: () => Promise<any>
   lqip?: Lqip;
   fileName?: string;
@@ -21,10 +21,8 @@ export class ImageKitConfiguration {
   sdkVersion?: string;
 }
 
-@Injectable({
-  providedIn: 'root'
-})
-export class ImagekitioAngularService {
+@Injectable()
+export class ImagekitService {
 
   _ikInstance: any;
   constructor(private configuration: ImageKitConfiguration) {
diff --git a/sdk/tests/sdk-tests/ik-image.component.spec.ts b/sdk/tests/sdk-tests/ik-image.component.spec.ts
@@ -1,23 +1,23 @@
 import { ElementRef } from "@angular/core";
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { IkImageComponent } from "../../projects/imagekitio-angular/src/lib/ik-image/ik-image.component";
-import { ImagekitioAngularService } from "../../projects/imagekitio-angular/src/lib/imagekitio-angular.service";
+import { ImagekitService } from "../../projects/imagekitio-angular/src/lib/imagekitio-angular.service";
 import { IkImageComponentOptions, LqipOptions } from '../../projects/imagekitio-angular/src/lib/utility/ik-type-def-collection'
 
 describe("IkImageComponent", () => {
   let component: IkImageComponent;
-  let imageKitService: ImagekitioAngularService;
+  let imageKitService: ImagekitService;
   let fixture: ComponentFixture<IkImageComponent>;
 
   beforeEach(() => {
-    imageKitService = new ImagekitioAngularService({
+    imageKitService = new ImagekitService({
       urlEndpoint: "https://ik.imagekit.io/company/",
       publicKey: "abc",
     });
     TestBed.configureTestingModule({
       declarations: [IkImageComponent],
       providers: [ {
-        provide: ImagekitioAngularService, useValue: imageKitService
+        provide: ImagekitService, useValue: imageKitService
       }]
     }).compileComponents();
     fixture = TestBed.createComponent(IkImageComponent);
@@ -37,8 +37,8 @@ describe("IkImageComponent", () => {
 
   it("Presence and absence of trailing slash in urlEndpoint should not result in double slash (//) in the returned url", () => {
     let comp: IkImageComponent;
-    let iKService: ImagekitioAngularService;
-    iKService = new ImagekitioAngularService({
+    let iKService: ImagekitService;
+    iKService = new ImagekitService({
       urlEndpoint: "https://ik.imagekit.io/company",
       publicKey: "abc",
     });
@@ -61,8 +61,8 @@ describe("IkImageComponent", () => {
 
   it("Presence and absence of leading slash in path parameter should not result in double slash (//) in the returned url", () => {
     let comp: IkImageComponent;
-    let iKService: ImagekitioAngularService;
-    iKService = new ImagekitioAngularService({
+    let iKService: ImagekitService;
+    iKService = new ImagekitService({
       urlEndpoint: "https://ik.imagekit.io/company/",
       publicKey: "abc",
     });
diff --git a/sdk/tests/sdk-tests/ik-upload.component.spec.ts b/sdk/tests/sdk-tests/ik-upload.component.spec.ts
@@ -1,12 +1,12 @@
 import { ComponentFixture, TestBed } from '@angular/core/testing';
-import { ImageKitConfiguration, ImagekitioAngularService } from "../../projects/imagekitio-angular/src/lib/imagekitio-angular.service";
+import { ImageKitConfiguration, ImagekitService } from "../../projects/imagekitio-angular/src/lib/imagekitio-angular.service";
 import { IkUploadComponent } from "../../projects/imagekitio-angular/src/lib/ik-upload/ik-upload.component";
 import { IkUploadComponentOptions } from '../../projects/imagekitio-angular/src/lib/utility/ik-type-def-collection';
 import { EventEmitter } from '@angular/core';
 
 describe("IkUploadComponent", () => {
   let component: IkUploadComponent;
-  let imageKitService: ImagekitioAngularService;
+  let imageKitService: ImagekitService;
   let imageKitConfiguration: ImageKitConfiguration;
   let fixture: ComponentFixture<IkUploadComponent>;
 
@@ -36,7 +36,7 @@ describe("IkUploadComponent", () => {
     TestBed.configureTestingModule({
       declarations: [IkUploadComponent],
       providers: [ 
-        {provide: ImagekitioAngularService, useValue: imageKitService},
+        {provide: ImagekitService, useValue: imageKitService},
         {provide: ImageKitConfiguration, useValue: imageKitConfiguration}
       ]
     }).compileComponents();
diff --git a/sdk/tests/sdk-tests/ik-video.component.spec.ts b/sdk/tests/sdk-tests/ik-video.component.spec.ts
@@ -1,23 +1,23 @@
 import { ElementRef } from "@angular/core";
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { IkVideoComponent } from "../../projects/imagekitio-angular/src/lib/ik-video/ik-video.component";
-import { ImagekitioAngularService } from "../../projects/imagekitio-angular/src/lib/imagekitio-angular.service";
+import { ImagekitService } from "../../projects/imagekitio-angular/src/lib/imagekitio-angular.service";
 import { IkVideoComponentOptions } from '../../projects/imagekitio-angular/src/lib/utility/ik-type-def-collection'
 
 describe("IkVideoComponent", () => {
   let component: IkVideoComponent;
-  let imageKitService: ImagekitioAngularService;
+  let imageKitService: ImagekitService;
   let fixture: ComponentFixture<IkVideoComponent>;
 
   beforeEach(() => {
-    imageKitService = new ImagekitioAngularService({
+    imageKitService = new ImagekitService({
       urlEndpoint: "https://ik.imagekit.io/company/",
       publicKey: "abc",
     });
     TestBed.configureTestingModule({
       declarations: [IkVideoComponent],
       providers: [ {
-        provide: ImagekitioAngularService, useValue: imageKitService
+        provide: ImagekitService, useValue: imageKitService
       }]
     }).compileComponents();
     fixture = TestBed.createComponent(IkVideoComponent);
@@ -39,8 +39,8 @@ describe("IkVideoComponent", () => {
 
   it("Presence and absence of leading slash in path parameter should not result in double slash (//) in the returned url", () => {
     let comp: IkVideoComponent;
-    let iKService: ImagekitioAngularService;
-    iKService = new ImagekitioAngularService({
+    let iKService: ImagekitService;
+    iKService = new ImagekitService({
       urlEndpoint: "https://ik.imagekit.io/company/",
       publicKey: "abc",
     });
diff --git a/sdk/tests/sdk-tests/imagekit.service.spec.ts b/sdk/tests/sdk-tests/imagekit.service.spec.ts
@@ -1,9 +1,9 @@
-import { ImagekitioAngularService } from "../../projects/imagekitio-angular/src/lib/imagekitio-angular.service";
+import { ImagekitService } from "../../projects/imagekitio-angular/src/lib/imagekitio-angular.service";
 
 describe("ImagekitService", () => {
-  let imagekitService: ImagekitioAngularService;
+  let imagekitService: ImagekitService;
   beforeEach(() => {
-    imagekitService = new ImagekitioAngularService({
+    imagekitService = new ImagekitService({
       urlEndpoint: "url",
       publicKey: "pub",
     });
