Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute ImageJ module over multiple images #29

Open
ctrueden opened this issue Mar 21, 2014 · 3 comments
Open

Execute ImageJ module over multiple images #29

ctrueden opened this issue Mar 21, 2014 · 3 comments
Milestone

Comments

@ctrueden
Copy link
Member

Right now, if an ImageJ module takes an image as input, it exposes that input to OMERO as a long called Image_ID. But the typical convention in OMERO clients is to use a parameter called IDs that is a string, formatted as a comma-separated list of image IDs. We could support this in the ImageJ-OMERO bridge by exposing image inputs as string IDs rather than long Image_ID, and then having special handling of any IDs parameters. The ImageJ-OMERO ModuleAdapter would need to split the IDs into a list, then call the module in a loop with each downloaded image of those IDs.

This is a quite special case—it becomes more complicated if an ImageJ module (such as Image Calculator) takes more than one input image. In such cases, we probably cannot do clever looping like this. But supporting single-image inputs in a loop this way would fulfill 80+% of use cases in a more convenient way.

/cc @jburel

@ctrueden
Copy link
Member Author

Very related (duplicate-ish, actually) to #24.

@ctrueden
Copy link
Member Author

There is now a SciJava batch processor thanks to @imagejan. Perhaps it makes most sense to utilize this framework for supporting execution of SciJava modules across multiple OMERO images?

@imagejan
Copy link
Member

imagejan commented Mar 26, 2018

On the batch-processor side, we could create a BatchInputProcessor interface and then an OMEROImgBatchInputProcessor (or some better name) that takes an IDs string and provides a list of Img objects (or whatever the module needs as input, as long as we can convert it) for a module to run (with batch-processor taking care of running the actual loop).
I was considering such an extensible plugin framework for both batch inputs and batch outputs and would like to hear opinions if that makes sense. See also scijava/batch-processor#14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants