remove noun reordering

Author: neverRare

CHANGELOG.md

@@ -36,7 +36,6 @@ do not communicate" instead of the grammatically awkward "I not communicate".
 - Implement modal verb translation e.g. "mi ken" into "I can".
 - Implement pagination. This also prevents browser crashes due to numerous
   translation output.
-- Reorder noun by perspective from third person then second then finally first.
 - Number as english words e.g. "ten" instead of "10" are now used for small
   numbers (≤ 20). Thanks soweli Eweke for the suggestion!
 - Remove "allow separate repeated modifiers". It'll be hardcoded to be turned

src/translator/fixer.ts

@@ -4,14 +4,6 @@ import * as English from "./ast.ts";
 import { encodeDeterminer } from "./determiner.ts";
 import { FilteredError } from "./error.ts";
 
-function rankNoun(noun: English.NounPhrase): number {
-  switch (noun.type) {
-    case "simple":
-      return ["third", "second", "first"].indexOf(noun.perspective);
-    case "compound":
-      return rankNoun(noun.nouns[0]);
-  }
-}
 function fixNounPhrase(noun: English.NounPhrase): English.NounPhrase {
   switch (noun.type) {
     case "simple":
@@ -34,9 +26,7 @@ function fixNounPhrase(noun: English.NounPhrase): English.NounPhrase {
     case "compound":
       return {
         ...noun,
-        nouns: noun.nouns
-          .map(fixNounPhrase)
-          .sort((a, b) => rankNoun(a) - rankNoun(b)),
+        nouns: noun.nouns.map(fixNounPhrase),
       };
   }
 }

src/translator/noun.ts

@@ -147,7 +147,6 @@ export function quantity(noun: English.NounPhrase): English.Quantity {
         case "and":
           return "plural";
         case "or":
-          // TODO: this doesn't work because nouns are reordered on `fixer.ts`
           return quantity(noun.nouns[noun.nouns.length - 1]);
       }
   }