feat: wire custom coin type and get bech32 prefix (#4569)

Author: julienrbrt

changelog.md

@@ -6,6 +6,10 @@
 
 - [#4509](https://github.com/ignite/cli/pull/4509) Upgrade to Go 1.24. Running `ignite doctor` migrates the scaffolded `tools.go` to the tool directive in the go.mod
 
+### Changes
+
+- [#4569](https://github.com/ignite/cli/pull/4569) Add flags to set coin type on commands. Add getters for bech32 prefix and coin type.
+
 ## [`v29.0.0-beta.1`](https://github.com/ignite/cli/releases/tag/v29.0.0-beta.1)
 
 ### Features

go.mod

@@ -3,6 +3,7 @@ module github.com/ignite/cli/v29
 go 1.24.0
 
 require (
+	cosmossdk.io/core v0.11.2
 	cosmossdk.io/math v1.5.0
 	dario.cat/mergo v1.0.1
 	github.com/99designs/keyring v1.2.2
@@ -80,7 +81,6 @@ require (
 	connectrpc.com/otelconnect v0.7.1 // indirect
 	cosmossdk.io/api v0.7.6 // indirect
 	cosmossdk.io/collections v0.4.0 // indirect
-	cosmossdk.io/core v0.11.2 // indirect
 	cosmossdk.io/depinject v1.1.0 // indirect
 	cosmossdk.io/errors v1.0.1 // indirect
 	cosmossdk.io/log v1.4.1 // indirect

ignite/cmd/account.go

@@ -13,6 +13,7 @@ import (
 
 const (
 	flagAddressPrefix  = "address-prefix"
+	flagCoinType       = "coin-type"
 	flagPassphrase     = "passphrase"
 	flagNonInteractive = "non-interactive"
 	flagKeyringBackend = "keyring-backend"
@@ -102,6 +103,17 @@ func getAddressPrefix(cmd *cobra.Command) string {
 	return prefix
 }
 
+func flagSetCoinType() *flag.FlagSet {
+	fs := flag.NewFlagSet("", flag.ContinueOnError)
+	fs.Uint32(flagCoinType, cosmosaccount.CoinTypeCosmos, "coin type to use for the account")
+	return fs
+}
+
+func getCoinType(cmd *cobra.Command) uint32 {
+	coinType, _ := cmd.Flags().GetUint32(flagCoinType)
+	return coinType
+}
+
 func flagSetAccountImport() *flag.FlagSet {
 	fs := flag.NewFlagSet("", flag.ContinueOnError)
 	fs.Bool(flagNonInteractive, false, "do not enter into interactive mode")

ignite/cmd/account_create.go

@@ -16,6 +16,8 @@ func NewAccountCreate() *cobra.Command {
 		RunE:  accountCreateHandler,
 	}
 
+	c.Flags().AddFlagSet(flagSetCoinType())
+
 	return c
 }
 
@@ -29,6 +31,7 @@ func accountCreateHandler(cmd *cobra.Command, args []string) error {
 	ca, err := cosmosaccount.New(
 		cosmosaccount.WithKeyringBackend(getKeyringBackend(cmd)),
 		cosmosaccount.WithHome(getKeyringDir(cmd)),
+		cosmosaccount.WithCoinType(getCoinType(cmd)),
 	)
 	if err != nil {
 		return errors.Errorf("unable to create registry: %w", err)

ignite/cmd/account_import.go

@@ -24,6 +24,7 @@ func NewAccountImport() *cobra.Command {
 
 	c.Flags().String(flagSecret, "", "Your mnemonic or path to your private key (use interactive mode instead to securely pass your mnemonic)")
 	c.Flags().AddFlagSet(flagSetAccountImport())
+	c.Flags().AddFlagSet(flagSetCoinType())
 
 	return c
 }
@@ -64,6 +65,7 @@ func accountImportHandler(cmd *cobra.Command, args []string) error {
 	ca, err := cosmosaccount.New(
 		cosmosaccount.WithKeyringBackend(getKeyringBackend(cmd)),
 		cosmosaccount.WithHome(getKeyringDir(cmd)),
+		cosmosaccount.WithCoinType(getCoinType(cmd)),
 	)
 	if err != nil {
 		return err

ignite/cmd/account_list.go

@@ -22,6 +22,7 @@ func accountListHandler(cmd *cobra.Command, _ []string) error {
 	ca, err := cosmosaccount.New(
 		cosmosaccount.WithKeyringBackend(getKeyringBackend(cmd)),
 		cosmosaccount.WithHome(getKeyringDir(cmd)),
+		cosmosaccount.WithBech32Prefix(getAddressPrefix(cmd)),
 	)
 	if err != nil {
 		return err

ignite/cmd/account_show.go

@@ -25,6 +25,7 @@ func accountShowHandler(cmd *cobra.Command, args []string) error {
 	ca, err := cosmosaccount.New(
 		cosmosaccount.WithKeyringBackend(getKeyringBackend(cmd)),
 		cosmosaccount.WithHome(getKeyringDir(cmd)),
+		cosmosaccount.WithBech32Prefix(getAddressPrefix(cmd)),
 	)
 	if err != nil {
 		return err

ignite/cmd/scaffold_chain.go

@@ -80,6 +80,7 @@ about Cosmos SDK on https://docs.cosmos.network
 
 	flagSetClearCache(c)
 	c.Flags().AddFlagSet(flagSetAccountPrefixes())
+	c.Flags().AddFlagSet(flagSetCoinType())
 	c.Flags().StringP(flagPath, "p", "", "create a project in a specific path")
 	c.Flags().Bool(flagNoDefaultModule, false, "create a project without a default module")
 	c.Flags().StringSlice(flagParams, []string{}, "add default module parameters")
@@ -102,6 +103,7 @@ func scaffoldChainHandler(cmd *cobra.Command, args []string) error {
 	var (
 		name          = args[0]
 		addressPrefix = getAddressPrefix(cmd)
+		coinType      = getCoinType(cmd)
 		appPath       = flagGetPath(cmd)
 
 		noDefaultModule, _ = cmd.Flags().GetBool(flagNoDefaultModule)
@@ -133,6 +135,7 @@ func scaffoldChainHandler(cmd *cobra.Command, args []string) error {
 		appPath,
 		name,
 		addressPrefix,
+		coinType,
 		protoDir,
 		noDefaultModule,
 		minimal,

ignite/cmd/scaffold_chain_registry.go

@@ -55,7 +55,7 @@ func scaffoldChainRegistryFiles(cmd *cobra.Command, _ []string) error {
 		return err
 	}
 
-	if err = sc.AddChainRegistryFiles(c, cfg); err != nil {
+	if err = sc.CreateChainRegistryFiles(c, cfg); err != nil {
 		return err
 	}
 

ignite/cmd/testnet_inplace.go

@@ -30,6 +30,8 @@ We can create a testnet from the local network state and mint additional coins f
 	c.Flags().AddFlagSet(flagSetCheckDependencies())
 	c.Flags().AddFlagSet(flagSetSkipProto())
 	c.Flags().AddFlagSet(flagSetVerbose())
+	c.Flags().AddFlagSet(flagSetAccountPrefixes())
+	c.Flags().AddFlagSet(flagSetCoinType())
 
 	c.Flags().Bool(flagQuitOnFail, false, "quit program if the app fails to start")
 	return c
@@ -71,17 +73,27 @@ func testnetInplace(cmd *cobra.Command, session *cliui.Session) error {
 	if err != nil {
 		return err
 	}
+
 	home, err := c.Home()
 	if err != nil {
 		return err
 	}
+
 	keyringBackend, err := c.KeyringBackend()
 	if err != nil {
 		return err
 	}
+
+	prefix := getAddressPrefix(cmd)
+	addressCodec := address.NewBech32Codec(prefix)
+	valAddressCodec := address.NewBech32Codec(prefix + "valoper")
+	coinType := getCoinType(cmd)
+
 	ca, err := cosmosaccount.New(
 		cosmosaccount.WithKeyringBackend(cosmosaccount.KeyringBackend(keyringBackend)),
 		cosmosaccount.WithHome(home),
+		cosmosaccount.WithBech32Prefix(prefix),
+		cosmosaccount.WithCoinType(coinType),
 	)
 	if err != nil {
 		return err
@@ -93,9 +105,6 @@ func testnetInplace(cmd *cobra.Command, session *cliui.Session) error {
 		accErr          *cosmosaccount.AccountDoesNotExistError
 	)
 
-	prefix := getAddressPrefix(cmd)
-	addressCodec := address.NewBech32Codec(prefix)
-	valAddressCodec := address.NewBech32Codec(prefix + "valoper")
 	for _, acc := range cfg.Accounts {
 		sdkAcc, err := ca.GetByName(acc.Name)
 		if errors.As(err, &accErr) {
@@ -138,5 +147,6 @@ func testnetInplace(cmd *cobra.Command, session *cliui.Session) error {
 		NewOperatorAddress: operatorAddressStr,
 		AccountsToFund:     accounts,
 	}
+
 	return c.TestnetInPlace(cmd.Context(), args)
 }

ignite/pkg/chainregistry/chain.go

@@ -19,7 +19,7 @@ type Chain struct {
 	DaemonName   string      `json:"daemon_name"`
 	NodeHome     string      `json:"node_home"`
 	KeyAlgos     []KeyAlgos  `json:"key_algos"`
-	Slip44       int         `json:"slip44"`
+	Slip44       uint32      `json:"slip44"`
 	Fees         Fees        `json:"fees"`
 	Staking      Staking     `json:"staking"`
 	Codebase     Codebase    `json:"codebase"`

ignite/pkg/cosmosaccount/cosmosaccount.go

@@ -9,21 +9,23 @@ import (
 	dkeyring "github.com/99designs/keyring"
 	"github.com/cosmos/go-bip39"
 
+	addresscodec "cosmossdk.io/core/address"
+
 	"github.com/cosmos/cosmos-sdk/codec"
+	"github.com/cosmos/cosmos-sdk/codec/address"
 	"github.com/cosmos/cosmos-sdk/codec/types"
 	cryptocodec "github.com/cosmos/cosmos-sdk/crypto/codec"
 	"github.com/cosmos/cosmos-sdk/crypto/hd"
 	"github.com/cosmos/cosmos-sdk/crypto/keyring"
 	sdktypes "github.com/cosmos/cosmos-sdk/types"
-	"github.com/cosmos/cosmos-sdk/types/bech32"
 	sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
 
 	"github.com/ignite/cli/v29/ignite/pkg/errors"
 )
 
 const (
 	// KeyringServiceName used for the name of keyring in OS backend.
-	KeyringServiceName = "starport"
+	KeyringServiceName = "ignite"
 
 	// DefaultAccount is the name of the default account.
 	DefaultAccount = "default"
@@ -35,6 +37,7 @@ var KeyringHome = os.ExpandEnv("$HOME/.ignite/accounts")
 var ErrAccountExists = errors.New("account already exists")
 
 const (
+	CoinTypeCosmos      = sdktypes.CoinType
 	AccountPrefixCosmos = "cosmos"
 )
 
@@ -59,6 +62,8 @@ type Registry struct {
 	homePath           string
 	keyringServiceName string
 	keyringBackend     KeyringBackend
+	addressCodec       addresscodec.Codec
+	coinType           uint32
 
 	Keyring keyring.Keyring
 }
@@ -84,12 +89,26 @@ func WithKeyringBackend(backend KeyringBackend) Option {
 	}
 }
 
+func WithBech32Prefix(prefix string) Option {
+	return func(c *Registry) {
+		c.addressCodec = address.NewBech32Codec(prefix)
+	}
+}
+
+func WithCoinType(coinType uint32) Option {
+	return func(c *Registry) {
+		c.coinType = coinType
+	}
+}
+
 // New creates a new registry to manage accounts.
 func New(options ...Option) (Registry, error) {
 	r := Registry{
 		keyringServiceName: sdktypes.KeyringServiceName(),
 		keyringBackend:     KeyringTest,
 		homePath:           KeyringHome,
+		addressCodec:       address.NewBech32Codec(AccountPrefixCosmos),
+		coinType:           CoinTypeCosmos,
 	}
 
 	for _, apply := range options {
@@ -146,7 +165,13 @@ func (a Account) Address(accPrefix string) (string, error) {
 		return "", err
 	}
 
-	return toBech32(accPrefix, pk.Address())
+	addressCodec := address.NewBech32Codec(accPrefix)
+	addr, err := addressCodec.BytesToString(pk.Address())
+	if err != nil {
+		return "", err
+	}
+
+	return addr, nil
 }
 
 // PubKey returns a public key for account.
@@ -159,14 +184,6 @@ func (a Account) PubKey() (string, error) {
 	return pk.String(), nil
 }
 
-func toBech32(prefix string, addr []byte) (string, error) {
-	bech32Addr, err := bech32.ConvertAndEncode(prefix, addr)
-	if err != nil {
-		return "", err
-	}
-	return bech32Addr, nil
-}
-
 // EnsureDefaultAccount ensures that default account exists.
 func (r Registry) EnsureDefaultAccount() error {
 	_, err := r.GetByName(DefaultAccount)
@@ -289,11 +306,11 @@ func (r Registry) GetByName(name string) (Account, error) {
 
 // GetByAddress returns an account by its address.
 func (r Registry) GetByAddress(address string) (Account, error) {
-	sdkAddr, err := sdktypes.AccAddressFromBech32(address)
+	sdkAddr, err := r.addressCodec.StringToBytes(address)
 	if err != nil {
 		return Account{}, err
 	}
-	record, err := r.Keyring.KeyByAddress(sdkAddr)
+	record, err := r.Keyring.KeyByAddress(sdktypes.AccAddress(sdkAddr))
 	if errors.Is(err, dkeyring.ErrKeyNotFound) || errors.Is(err, sdkerrors.ErrKeyNotFound) {
 		return Account{}, &AccountDoesNotExistError{address}
 	}
@@ -335,7 +352,7 @@ func (r Registry) DeleteByName(name string) error {
 }
 
 func (r Registry) hdPath() string {
-	return hd.CreateHDPath(sdktypes.CoinType, 0, 0).String()
+	return hd.CreateHDPath(r.coinType, 0, 0).String()
 }
 
 func (r Registry) algo() (keyring.SignatureAlgo, error) {

ignite/pkg/cosmosclient/bank.go

@@ -26,7 +26,7 @@ func (c Client) BankBalances(ctx context.Context, address string, pagination *qu
 }
 
 func (c Client) BankSendTx(ctx context.Context, fromAccount cosmosaccount.Account, toAddress string, amount sdk.Coins) (TxService, error) {
-	addr, err := fromAccount.Address(c.addressPrefix)
+	addr, err := fromAccount.Address(c.bech32Prefix)
 	if err != nil {
 		return TxService{}, err
 	}