Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and simplify Publish method from Network package #157

Open
lumtis opened this issue Aug 9, 2022 · 0 comments
Open

Refactor and simplify Publish method from Network package #157

lumtis opened this issue Aug 9, 2022 · 0 comments

Comments

@lumtis
Copy link

lumtis commented Aug 9, 2022

The Publish method includes too much logic https://github.com/ignite/cli/blob/0877841f2c10e731ae4ef3925167ce8c5df69506/ignite/services/network/publish.go#L89

Campaign creation, voucher minting, etc...

The typical flow of the command is to publish a chain and so this behavior should be easy to read from the method.
We should move campaign, voucher and mainnet related logic in sub-method for better readability

@salmad3 salmad3 transferred this issue from ignite/cli Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Discuss
Development

No branches or pull requests

2 participants