Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network prepare: support updating balance of existing genesis accounts in genesis #153

Open
Tracked by #159
lumtis opened this issue May 11, 2022 · 1 comment
Open
Tracked by #159

Comments

@lumtis
Copy link

lumtis commented May 11, 2022

Is your feature request related to a problem? Please describe.
For mainnet chain, a token distribution might be already defined in the initial genesis for the chain with special allocations.
A account with token distribution might also redeem vouchers.
Therefore, we must support in the genesis generation, increasing the balance of an already existing account.

Describe the solution you'd like
We currently use appd add-genesis-account ... in genesis generation to add genesis accounts from launch information.
Since add-genesis-account fails for accounts that already exist in the genesis we should instead update manually the genesis by searching and increasing the account balance.

We can:

  • Always manually update the genesis by adding an entry for the account when it doesn't exist
  • Only perform the manual update if the account already exists. add-genesis-account is used otherwise

Cons:
We should take care if some chains have additional logic in add-genesis-account other than updating the genesis. That could be the case for evm chains

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Discuss
Development

No branches or pull requests

2 participants
@lumtis and others