-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INIT: Enable Extension to Call Ignite Commands #117
Comments
That's already possible like this: https://github.com/ignite/apps/blob/e5cd28a/appregistry/cmd/install.go#L34-L39 |
I was doing some tests trying to call the commands through GRPC, but in the end, it was the same solution with overengineer. WDYT? |
I look actually pretty handy, but it is indeed less flexible than just importing the cobra command. We would need a way to get stderr, stdout from that API. |
The trick to importing the Cobra command is the ignite version. The version from the terminal can be different from the version from the app using an old building. However, using thought GRPC can break the app if the commands change. |
Right, 100% agree, adding calling it via grpc is great for that, however we may want the api to do more (outputs, checking version indeed) |
Add the ability to the extension to call the ignite commands
The text was updated successfully, but these errors were encountered: