Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INIT: Enable Extension to Call Ignite Commands #117

Open
Pantani opened this issue Jul 14, 2024 · 5 comments
Open

INIT: Enable Extension to Call Ignite Commands #117

Pantani opened this issue Jul 14, 2024 · 5 comments

Comments

@Pantani
Copy link
Collaborator

Pantani commented Jul 14, 2024

Add the ability to the extension to call the ignite commands

@julienrbrt
Copy link
Member

That's already possible like this: https://github.com/ignite/apps/blob/e5cd28a/appregistry/cmd/install.go#L34-L39
Not the best I admit but does the job.
What are you thinking about?

@Pantani
Copy link
Collaborator Author

Pantani commented Jul 15, 2024

I was doing some tests trying to call the commands through GRPC, but in the end, it was the same solution with overengineer.

ignite/cli#4252

WDYT?

@julienrbrt
Copy link
Member

julienrbrt commented Jul 15, 2024

I look actually pretty handy, but it is indeed less flexible than just importing the cobra command. We would need a way to get stderr, stdout from that API.
However me may need to use this if we don't want to depend on cobra in extensions.

@Pantani
Copy link
Collaborator Author

Pantani commented Jul 15, 2024

The trick to importing the Cobra command is the ignite version. The version from the terminal can be different from the version from the app using an old building. However, using thought GRPC can break the app if the commands change.

@julienrbrt
Copy link
Member

Right, 100% agree, adding calling it via grpc is great for that, however we may want the api to do more (outputs, checking version indeed)

@salmad3 salmad3 changed the title feat: add the ability to the extension to call the ignite commands INIT: Enable Extension to Call Ignite Commands Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Discuss
Development

No branches or pull requests

3 participants