Skip to content

Commit e8588c7

Browse files
joshuaspencejoshuaspence
committed
Fix text lint issues
Summary: Ref T5105. This is a proof-of-concept for D11458. Test Plan: `arc lint --everything` Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Maniphest Tasks: T5105 Differential Revision: https://secure.phabricator.com/D11641
1 parent 9e0ea2c commit e8588c7

11 files changed

+45
-37
lines changed

‎.arclint

+2-19
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
{
22
"exclude": [
3-
"(^externals/)",
4-
"(^src/console/__tests__/wrap/.*\\.txt(\\.expect)?$)",
5-
"(^src/markup/engine/__tests__/remarkup/.*\\.txt$)",
6-
"(^src/markup/syntax/highlighter/__tests__/xhpast/.*\\.(expect|source)$)"
3+
"(^externals/)"
74
],
85
"linters": {
96
"chmod": {
@@ -41,21 +38,7 @@
4138
"type": "spelling"
4239
},
4340
"text": {
44-
"type": "text",
45-
"exclude": [
46-
"(^support/xhpast/\\w+\\.(hpp|l|y)$)",
47-
"(^\\.arclint$)"
48-
]
49-
},
50-
"text-without-length": {
51-
"type": "text",
52-
"severity": {
53-
"3": "disabled"
54-
},
55-
"include": [
56-
"(^support/xhpast/\\w+\\.(hpp|l|y)$)",
57-
"(^\\.arclint$)"
58-
]
41+
"type": "text"
5942
},
6043
"xhpast": {
6144
"type": "xhpast",

‎.editorconfig

+35-9
Original file line numberDiff line numberDiff line change
@@ -3,26 +3,52 @@
33
[*]
44
indent_style = space
55
indent_size = 2
6+
end_of_line = lf
67
charset = utf-8
78
trim_trailing_whitespace = true
89
insert_final_newline = true
10+
max_line_length = 80
11+
12+
[Makefile]
13+
indent_style = tab
14+
15+
[.arclint]
16+
max_line_length =
17+
18+
[externals/**]
19+
indent_style =
20+
indent_size =
21+
trim_trailing_whitespace = false
22+
insert_final_newline = false
23+
24+
[resources/ssl/*.pem]
25+
max_line_length =
26+
27+
[src/console/__tests__/wrap/*.txt{,.expect}]
28+
trim_trailing_whitespace = false
29+
max_line_length =
930

1031
[src/markup/engine/__tests__/remarkup/*.txt]
1132
trim_trailing_whitespace = false
33+
max_line_length =
34+
35+
[src/markup/syntax/highlighter/__tests__/phpfragment/*.expect]
36+
max_line_length =
37+
38+
[src/markup/syntax/highlighter/__tests__/xhpast/*.expect]
39+
max_line_length =
40+
41+
[src/markup/syntax/highlighter/__tests__/xhpast/*.{expect,source}]
1242
insert_final_newline = false
1343

1444
[src/parser/__tests__/json/*.data]
1545
insert_final_newline = false
1646

47+
[src/parser/__tests__/json/*.{data,json}]
48+
max_line_length =
49+
1750
[src/parser/__tests__/languageguesser/*]
1851
indent_style =
1952

20-
[Makefile]
21-
indent_style = tab
22-
23-
[externals/**]
24-
; Use editor default (possible autodetection).
25-
indent_style =
26-
indent_size =
27-
trim_trailing_whitespace = false
28-
insert_final_newline = false
53+
[support/xhpast/*.{cpp,hpp,l,y}]
54+
max_line_length =

‎LICENSE

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
Apache License
32
Version 2.0, January 2004
43
http://www.apache.org/licenses/

‎src/console/__tests__/wrap/long.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Say MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM every day.
1+
Say MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM every day.

‎src/console/__tests__/wrap/long.txt.expect

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
Say
22
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
3-
every day.
3+
every day.

‎src/console/__tests__/wrap/plain.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Morbi auctor commodo libero, vel interdum leo commodo nec. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Vestibulum dictum pretium lorem ac commodo. Vivamus ullamcorper neque et velit interdum ornare. Fusce adipiscing metus non sem porttitor scelerisque. Aliquam mattis sem non tortor semper eget fermentum libero faucibus. Nam vulputate mauris at nunc bibendum mollis. Aliquam mattis rutrum turpis a fringilla. Mauris quis nulla eget nunc mollis pharetra id sit amet arcu. Nam ut urna in ligula facilisis scelerisque in nec massa. Morbi posuere, turpis in bibendum fringilla, augue felis gravida est, vitae convallis quam nunc at tellus.
1+
Morbi auctor commodo libero, vel interdum leo commodo nec. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Vestibulum dictum pretium lorem ac commodo. Vivamus ullamcorper neque et velit interdum ornare. Fusce adipiscing metus non sem porttitor scelerisque. Aliquam mattis sem non tortor semper eget fermentum libero faucibus. Nam vulputate mauris at nunc bibendum mollis. Aliquam mattis rutrum turpis a fringilla. Mauris quis nulla eget nunc mollis pharetra id sit amet arcu. Nam ut urna in ligula facilisis scelerisque in nec massa. Morbi posuere, turpis in bibendum fringilla, augue felis gravida est, vitae convallis quam nunc at tellus.

‎src/console/__tests__/wrap/plain.txt.expect

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ sem non tortor semper eget fermentum libero faucibus. Nam vulputate mauris at
66
nunc bibendum mollis. Aliquam mattis rutrum turpis a fringilla. Mauris quis
77
nulla eget nunc mollis pharetra id sit amet arcu. Nam ut urna in ligula
88
facilisis scelerisque in nec massa. Morbi posuere, turpis in bibendum
9-
fringilla, augue felis gravida est, vitae convallis quam nunc at tellus.
9+
fringilla, augue felis gravida est, vitae convallis quam nunc at tellus.

‎src/console/__tests__/wrap/trailing-space-prompt.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Do you want to do stuff? [y/N]
1+
Do you want to do stuff? [y/N]

‎src/console/__tests__/wrap/trailing-space-prompt.txt.expect

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Do you want to do stuff? [y/N]
1+
Do you want to do stuff? [y/N]

‎src/console/__tests__/wrap/utf8.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
☃☃☃☃☃☃ ☃☃☃☃☃☃ ☃☃☃☃☃☃ ☃☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃
1+
☃☃☃☃☃☃ ☃☃☃☃☃☃ ☃☃☃☃☃☃ ☃☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃

‎src/console/__tests__/wrap/utf8.txt.expect

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
☃☃☃☃☃☃ ☃☃☃☃☃☃ ☃☃☃☃☃☃ ☃☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃
2-
☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃
2+
☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃ ☃☃☃☃☃

0 commit comments

Comments
 (0)